amogh-jahagirdar commented on code in PR #10131: URL: https://github.com/apache/iceberg/pull/10131#discussion_r1562913308
########## spark/v3.5/spark/src/test/java/org/apache/iceberg/spark/TestBaseWithCatalog.java: ########## @@ -73,7 +73,7 @@ public static void dropWarehouse() throws IOException { } } - @TempDir protected File temp; + @TempDir protected java.nio.file.Path temp; Review Comment: Super nit, but while we're doing this: I find it easier to read if we don't use the fully qualified Path name here, rather use the fullly qualified name for the hadoop `Path` in `dropWarehouse`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org