Re: [PR] Spark: Bypass Spark's ViewCatalog API when replacing a view [iceberg]

nastra commented on code in PR #9596: URL: https://github.com/apache/iceberg/pull/9596#discussion_r1584541374 ## spark/v3.5/spark/src/main/java/org/apache/iceberg/spark/SparkCatalog.java: ## @@ -608,6 +608,53 @@ public View createView( "Creating a view is not supported

Re: [PR] Spark: Bypass Spark's ViewCatalog API when replacing a view [iceberg]

nastra commented on code in PR #9596: URL: https://github.com/apache/iceberg/pull/9596#discussion_r1476195226 ## spark/v3.5/spark/src/main/java/org/apache/iceberg/spark/SparkCatalog.java: ## @@ -608,6 +608,53 @@ public View createView( "Creating a view is not supported

Re: [PR] Spark: Bypass Spark's ViewCatalog API when replacing a view [iceberg]

nastra commented on code in PR #9596: URL: https://github.com/apache/iceberg/pull/9596#discussion_r1474887880 ## spark/v3.5/spark/src/main/java/org/apache/iceberg/spark/SparkCatalog.java: ## @@ -608,6 +608,53 @@ public View createView( "Creating a view is not supported

Re: [PR] Spark: Bypass Spark's ViewCatalog API when replacing a view [iceberg]

rdblue commented on code in PR #9596: URL: https://github.com/apache/iceberg/pull/9596#discussion_r1474882524 ## spark/v3.5/spark/src/main/java/org/apache/iceberg/spark/SparkCatalog.java: ## @@ -608,6 +608,53 @@ public View createView( "Creating a view is not supported

Re: [PR] Spark: Bypass Spark's ViewCatalog API when replacing a view [iceberg]

rdblue merged PR #9596: URL: https://github.com/apache/iceberg/pull/9596 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apac

Re: [PR] Spark: Bypass Spark's ViewCatalog API when replacing a view [iceberg]

rdblue commented on code in PR #9596: URL: https://github.com/apache/iceberg/pull/9596#discussion_r1474880493 ## spark/v3.5/spark/src/main/java/org/apache/iceberg/spark/SparkCatalog.java: ## @@ -608,6 +608,53 @@ public View createView( "Creating a view is not supported

Re: [PR] Spark: Bypass Spark's ViewCatalog API when replacing a view [iceberg]

nastra commented on code in PR #9596: URL: https://github.com/apache/iceberg/pull/9596#discussion_r1474103589 ## spark/v3.5/spark/src/main/java/org/apache/iceberg/spark/SparkCatalog.java: ## @@ -608,6 +608,53 @@ public View createView( "Creating a view is not supported

Re: [PR] Spark: Bypass Spark's ViewCatalog API when replacing a view [iceberg]

nastra commented on code in PR #9596: URL: https://github.com/apache/iceberg/pull/9596#discussion_r1474100353 ## spark/v3.5/spark/src/main/java/org/apache/iceberg/spark/SparkCatalog.java: ## @@ -608,6 +608,53 @@ public View createView( "Creating a view is not supported

Re: [PR] Spark: Bypass Spark's ViewCatalog API when replacing a view [iceberg]

nastra commented on code in PR #9596: URL: https://github.com/apache/iceberg/pull/9596#discussion_r1474084355 ## spark/v3.5/spark/src/main/java/org/apache/iceberg/spark/SparkCatalog.java: ## @@ -608,6 +608,53 @@ public View createView( "Creating a view is not supported

Re: [PR] Spark: Bypass Spark's ViewCatalog API when replacing a view [iceberg]

nastra commented on code in PR #9596: URL: https://github.com/apache/iceberg/pull/9596#discussion_r1474076108 ## spark/v3.5/spark-extensions/src/test/java/org/apache/iceberg/spark/extensions/TestViews.java: ## @@ -1362,6 +1362,21 @@ public void showCreateComplexView() { ass

Re: [PR] Spark: Bypass Spark's ViewCatalog API when replacing a view [iceberg]

rdblue commented on code in PR #9596: URL: https://github.com/apache/iceberg/pull/9596#discussion_r1473189034 ## spark/v3.5/spark/src/main/java/org/apache/iceberg/spark/SparkCatalog.java: ## @@ -608,6 +608,53 @@ public View createView( "Creating a view is not supported

Re: [PR] Spark: Bypass Spark's ViewCatalog API when replacing a view [iceberg]

rdblue commented on code in PR #9596: URL: https://github.com/apache/iceberg/pull/9596#discussion_r1473187177 ## spark/v3.5/spark/src/main/java/org/apache/iceberg/spark/SparkCatalog.java: ## @@ -608,6 +608,53 @@ public View createView( "Creating a view is not supported

Re: [PR] Spark: Bypass Spark's ViewCatalog API when replacing a view [iceberg]

rdblue commented on code in PR #9596: URL: https://github.com/apache/iceberg/pull/9596#discussion_r1473180927 ## spark/v3.5/spark/src/main/java/org/apache/iceberg/spark/SparkCatalog.java: ## @@ -608,6 +608,53 @@ public View createView( "Creating a view is not supported

Re: [PR] Spark: Bypass Spark's ViewCatalog API when replacing a view [iceberg]

rdblue commented on code in PR #9596: URL: https://github.com/apache/iceberg/pull/9596#discussion_r1473179743 ## spark/v3.5/spark/src/main/java/org/apache/iceberg/spark/SparkCatalog.java: ## @@ -608,6 +608,53 @@ public View createView( "Creating a view is not supported

Re: [PR] Spark: Bypass Spark's ViewCatalog API when replacing a view [iceberg]

rdblue commented on code in PR #9596: URL: https://github.com/apache/iceberg/pull/9596#discussion_r1473178368 ## spark/v3.5/spark-extensions/src/test/java/org/apache/iceberg/spark/extensions/TestViews.java: ## @@ -1362,6 +1362,21 @@ public void showCreateComplexView() { ass

Re: [PR] Spark: Bypass Spark's ViewCatalog API when replacing a view [iceberg]

rdblue commented on code in PR #9596: URL: https://github.com/apache/iceberg/pull/9596#discussion_r1473176643 ## spark/v3.5/spark/src/main/java/org/apache/iceberg/spark/SupportsReplacingViews.java: ## @@ -0,0 +1,56 @@ +/* + * Licensed to the Apache Software Foundation (ASF) unde

Re: [PR] Spark: Bypass Spark's ViewCatalog API when replacing a view [iceberg]

nastra commented on code in PR #9596: URL: https://github.com/apache/iceberg/pull/9596#discussion_r1472820936 ## spark/v3.5/spark/src/main/java/org/apache/iceberg/spark/SupportsViewReplace.java: ## @@ -0,0 +1,56 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under o

[PR] Spark: Bypass Spark's ViewCatalog API when replacing a view [iceberg]

nastra opened a new pull request, #9596: URL: https://github.com/apache/iceberg/pull/9596 Spark's `ViewCatalog` API doesn't have a `replace()` in 3.5 as it was only introduced later. Therefore we're bypassing Spark's `ViewCatalog` so that we can keep the view's history after executing a `CR