rdblue commented on code in PR #9596:
URL: https://github.com/apache/iceberg/pull/9596#discussion_r1473178368
##########
spark/v3.5/spark-extensions/src/test/java/org/apache/iceberg/spark/extensions/TestViews.java:
##########
@@ -1362,6 +1362,21 @@ public void showCreateComplexView() {
assertThat(sql("SHOW CREATE TABLE %s",
viewName)).containsExactly(row(expected));
}
+ @Test
+ public void createOrReplaceViewKeepsViewHistory() {
+ String viewName = viewName("viewWithHistoryAfterReplace");
+
+ sql("CREATE VIEW %s AS SELECT id, data FROM %s WHERE id <= 3", viewName,
tableName);
+
+ View view = viewCatalog().loadView(TableIdentifier.of(NAMESPACE,
viewName));
+ assertThat(view.history()).hasSize(1);
+
+ sql("CREATE OR REPLACE VIEW %s AS SELECT id FROM %s WHERE id <= 3",
viewName, tableName);
+
+ view = viewCatalog().loadView(TableIdentifier.of(NAMESPACE, viewName));
+ assertThat(view.history()).hasSize(2);
Review Comment:
It would be nice to also validate the SQL text and other properties to
ensure that we aren't incorrectly creating the new ViewVersion.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
