laithalzyoud commented on PR #10024:
URL: https://github.com/apache/iceberg/pull/10024#issuecomment-2284175571
I created the [PR](https://github.com/apache/iceberg/pull/10920) to just add
the interface, please feel to review it and provide feedback!
--
This is an automated message from th
laithalzyoud closed pull request #10024: Spark: Add CopyTable spark action
URL: https://github.com/apache/iceberg/pull/10024
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To
laithalzyoud commented on PR #10024:
URL: https://github.com/apache/iceberg/pull/10024#issuecomment-2282743507
Hey @huaxingao! I'm planning to continue working on it starting this week.
For now I'll close this PR and open a new one to just add the interface, once
we agree on the interface,
laithalzyoud commented on code in PR #10024:
URL: https://github.com/apache/iceberg/pull/10024#discussion_r1712976165
##
spark/v3.5/spark/src/main/java/org/apache/iceberg/spark/actions/BaseCopyTableSparkAction.java:
##
@@ -0,0 +1,871 @@
+/*
+ * Licensed to the Apache Software Fo
huaxingao commented on PR #10024:
URL: https://github.com/apache/iceberg/pull/10024#issuecomment-2274801248
@laithalzyoud Thanks for the thumbs-up! Could you please confirm if you are
planning to continue working on this PR, or would you like me to take over? I’m
happy to help in any way ne
moomindani commented on PR #10024:
URL: https://github.com/apache/iceberg/pull/10024#issuecomment-2257398666
@laithalzyoud I am super interested in this PR and it will unblock many use
cases. Are you working on this now?
--
This is an automated message from the Apache Git Service.
To resp
huaxingao commented on PR #10024:
URL: https://github.com/apache/iceberg/pull/10024#issuecomment-2256302276
@laithalzyoud Thanks for your work on this PR! I've noticed there hasn't
been activity for a while, and I wanted to check if you're still able to
continue working on it. If you're bus
laithalzyoud commented on PR #10024:
URL: https://github.com/apache/iceberg/pull/10024#issuecomment-2150442517
> @laithalzyoud : Are you planning to address the comments on this? This
feature is definitely useful. If not, I would like to take it up.
Hey @ajantha-bhat! Yes I'm planning
ajantha-bhat commented on PR #10024:
URL: https://github.com/apache/iceberg/pull/10024#issuecomment-2147313645
@laithalzyoud : Are you planning to address the comments on this? This
feature is definitely useful.
If not, I would like to take it up.
--
This is an automated message from
flyrain commented on PR #10024:
URL: https://github.com/apache/iceberg/pull/10024#issuecomment-2025617889
Thanks @laithalzyoud for taking lead for the copy table action. Agreed with
@amogh-jahagirdar, can we separated the PR to interface only PR, and
implementation PRs. That way, we can get
amogh-jahagirdar commented on code in PR #10024:
URL: https://github.com/apache/iceberg/pull/10024#discussion_r1543096333
##
spark/v3.5/spark/src/main/java/org/apache/iceberg/spark/actions/BaseCopyTableSparkAction.java:
##
@@ -0,0 +1,871 @@
+/*
+ * Licensed to the Apache Softwar
RussellSpitzer commented on PR #10024:
URL: https://github.com/apache/iceberg/pull/10024#issuecomment-2025287831
@flyrain You should take a look at this as well
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL a
jotarada commented on code in PR #10024:
URL: https://github.com/apache/iceberg/pull/10024#discussion_r1537942005
##
spark/v3.5/spark/src/main/java/org/apache/iceberg/spark/actions/BaseCopyTableSparkAction.java:
##
@@ -0,0 +1,871 @@
+/*
+ * Licensed to the Apache Software Founda
laithalzyoud commented on PR #10024:
URL: https://github.com/apache/iceberg/pull/10024#issuecomment-2018030997
> @laithalzyoud thanks for working on this. I just did a very quick
high-level review, but will do a more thorough one this week
Thanks for taking a look @nastra, I'll stash
nastra commented on PR #10024:
URL: https://github.com/apache/iceberg/pull/10024#issuecomment-2017811872
@laithalzyoud thanks for working on this. I just did a very quick high-level
review, but will do a more thorough one this week
--
This is an automated message from the Apache Git Servi
nastra commented on code in PR #10024:
URL: https://github.com/apache/iceberg/pull/10024#discussion_r1537451796
##
spark/v3.5/spark/src/main/java/org/apache/iceberg/spark/actions/BaseCopyTableSparkAction.java:
##
@@ -0,0 +1,871 @@
+/*
+ * Licensed to the Apache Software Foundati
nastra commented on code in PR #10024:
URL: https://github.com/apache/iceberg/pull/10024#discussion_r1537450457
##
core/src/main/java/org/apache/iceberg/TableMetadataUtil.java:
##
@@ -0,0 +1,134 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more co
nastra commented on code in PR #10024:
URL: https://github.com/apache/iceberg/pull/10024#discussion_r1537448543
##
spark/v3.5/spark/src/test/java/org/apache/iceberg/spark/actions/TestCopyTableAction.java:
##
@@ -0,0 +1,1044 @@
+/*
+ * Licensed to the Apache Software Foundation (
nastra commented on code in PR #10024:
URL: https://github.com/apache/iceberg/pull/10024#discussion_r1537447465
##
spark/v3.5/spark/src/test/java/org/apache/iceberg/spark/actions/TestCopyTableAction.java:
##
@@ -0,0 +1,1044 @@
+/*
+ * Licensed to the Apache Software Foundation (
nastra commented on code in PR #10024:
URL: https://github.com/apache/iceberg/pull/10024#discussion_r1537446954
##
spark/v3.5/spark/src/test/java/org/apache/iceberg/spark/actions/TestCopyTableAction.java:
##
@@ -0,0 +1,1044 @@
+/*
+ * Licensed to the Apache Software Foundation (
nastra commented on code in PR #10024:
URL: https://github.com/apache/iceberg/pull/10024#discussion_r1537445541
##
spark/v3.5/spark/src/test/java/org/apache/iceberg/spark/actions/TestCopyTableAction.java:
##
@@ -0,0 +1,1044 @@
+/*
+ * Licensed to the Apache Software Foundation (
nastra commented on code in PR #10024:
URL: https://github.com/apache/iceberg/pull/10024#discussion_r1537443842
##
core/src/main/java/org/apache/iceberg/actions/BaseCopyTableActionResult.java:
##
@@ -0,0 +1,57 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
nastra commented on PR #10024:
URL: https://github.com/apache/iceberg/pull/10024#issuecomment-2017794044
> Supports Spark 3.3, 3.4 and 3.5
We should probably first focus on a single Spark version (3.5) and once the
PR is merged, backport the changes to previous Spark versions. Otherwi
23 matches
Mail list logo
