Re: [PR] Retry connections in JDBC catalog with user configured error code list [iceberg]

2024-04-15 Thread via GitHub
jbonofre commented on code in PR #10140: URL: https://github.com/apache/iceberg/pull/10140#discussion_r1565856298 ## core/src/main/java/org/apache/iceberg/ClientPoolImpl.java: ## @@ -56,26 +67,36 @@ public R run(Action action, boolean retry) throws E, InterruptedExc C cli

Re: [PR] Retry connections in JDBC catalog with user configured error code list [iceberg]

2024-04-15 Thread via GitHub
amogh-jahagirdar commented on code in PR #10140: URL: https://github.com/apache/iceberg/pull/10140#discussion_r1565848626 ## core/src/main/java/org/apache/iceberg/ClientPoolImpl.java: ## @@ -56,26 +67,36 @@ public R run(Action action, boolean retry) throws E, InterruptedExc

Re: [PR] Retry connections in JDBC catalog with user configured error code list [iceberg]

2024-04-15 Thread via GitHub
amogh-jahagirdar commented on code in PR #10140: URL: https://github.com/apache/iceberg/pull/10140#discussion_r1565848626 ## core/src/main/java/org/apache/iceberg/ClientPoolImpl.java: ## @@ -56,26 +67,36 @@ public R run(Action action, boolean retry) throws E, InterruptedExc

Re: [PR] Retry connections in JDBC catalog with user configured error code list [iceberg]

2024-04-15 Thread via GitHub
cccs-eric commented on PR #10140: URL: https://github.com/apache/iceberg/pull/10140#issuecomment-2056558173 @amogh-jahagirdar I'd be happy with this fix since it will solve the problem my organization is facing. Thanks for looking into this and bringing the football past the goal line. 👍🏻

Re: [PR] Retry connections in JDBC catalog with user configured error code list [iceberg]

2024-04-15 Thread via GitHub
jbonofre commented on code in PR #10140: URL: https://github.com/apache/iceberg/pull/10140#discussion_r1565313138 ## core/src/main/java/org/apache/iceberg/jdbc/JdbcClientPool.java: ## @@ -21,17 +21,27 @@ import java.sql.Connection; import java.sql.DriverManager; import java.s

Re: [PR] Retry connections in JDBC catalog with user configured error code list [iceberg]

2024-04-15 Thread via GitHub
nastra commented on code in PR #10140: URL: https://github.com/apache/iceberg/pull/10140#discussion_r1565280613 ## core/src/main/java/org/apache/iceberg/jdbc/JdbcCatalog.java: ## @@ -72,6 +72,7 @@ public class JdbcCatalog extends BaseMetastoreViewCatalog implements Configur

Re: [PR] Retry connections in JDBC catalog with user configured error code list [iceberg]

2024-04-14 Thread via GitHub
jbonofre commented on code in PR #10140: URL: https://github.com/apache/iceberg/pull/10140#discussion_r1565208210 ## core/src/main/java/org/apache/iceberg/ClientPoolImpl.java: ## @@ -56,26 +67,36 @@ public R run(Action action, boolean retry) throws E, InterruptedExc C cli

Re: [PR] Retry connections in JDBC catalog with user configured error code list [iceberg]

2024-04-14 Thread via GitHub
ajantha-bhat commented on PR #10140: URL: https://github.com/apache/iceberg/pull/10140#issuecomment-2055350705 cc: @jbonofre -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

Re: [PR] Retry connections in JDBC catalog with user configured error code list [iceberg]

2024-04-14 Thread via GitHub
amogh-jahagirdar commented on code in PR #10140: URL: https://github.com/apache/iceberg/pull/10140#discussion_r1565013391 ## core/src/main/java/org/apache/iceberg/jdbc/JdbcClientPool.java: ## @@ -43,8 +53,16 @@ public JdbcClientPool(String dbUrl, Map props) { } public J

Re: [PR] Retry connections in JDBC catalog with user configured error code list [iceberg]

2024-04-14 Thread via GitHub
amogh-jahagirdar commented on code in PR #10140: URL: https://github.com/apache/iceberg/pull/10140#discussion_r1565013391 ## core/src/main/java/org/apache/iceberg/jdbc/JdbcClientPool.java: ## @@ -43,8 +53,16 @@ public JdbcClientPool(String dbUrl, Map props) { } public J

Re: [PR] Retry connections in JDBC catalog with user configured error code list [iceberg]

2024-04-14 Thread via GitHub
amogh-jahagirdar commented on PR #10140: URL: https://github.com/apache/iceberg/pull/10140#issuecomment-2054248088 Need to add tests -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific c

Re: [PR] Retry connections in JDBC catalog with user configured error code list [iceberg]

2024-04-14 Thread via GitHub
amogh-jahagirdar commented on code in PR #10140: URL: https://github.com/apache/iceberg/pull/10140#discussion_r1565006119 ## core/src/main/java/org/apache/iceberg/ClientPoolImpl.java: ## @@ -56,26 +67,36 @@ public R run(Action action, boolean retry) throws E, InterruptedExc