amogh-jahagirdar commented on code in PR #10140:
URL: https://github.com/apache/iceberg/pull/10140#discussion_r1565013391
##########
core/src/main/java/org/apache/iceberg/jdbc/JdbcClientPool.java:
##########
@@ -43,8 +53,16 @@ public JdbcClientPool(String dbUrl, Map<String, String>
props) {
}
public JdbcClientPool(int poolSize, String dbUrl, Map<String, String> props)
{
- super(poolSize, SQLNonTransientConnectionException.class, true);
+ super(poolSize, SQLTransientException.class, true);
properties = props;
+ retryableStatusCodes = Sets.newHashSet();
+ retryableStatusCodes.addAll(COMMON_RETRYABLE_CONNECTION_SQL_STATES);
+ String configuredRetryableStatuses =
props.get(JdbcCatalog.RETRYABLE_STATUS_CODES);
+ if (configuredRetryableStatuses != null) {
Review Comment:
I'm presenting this configuration option since at the moment I believe it's
the most practical way for people to work around production issues they hit
today.
Long term, if we separate JDBC catalog into a separate library (I forgot
where we landed on where JDBC fits in in terms of the catalog discussion that's
happened in the past) that library could define status codes for each common,
industry-standard database so a user doesn't have to specify anything.
See https://www.youtube.com/watch?v=uAQVGd5zV4I&t=1323s for the discussion
on catalogs in the future.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
