hussein-awala commented on PR #127:
URL: https://github.com/apache/iceberg-python/pull/127#issuecomment-1879277861
We need to merge https://github.com/apache/iceberg-python/pull/253 to fix
the failed tests in main.
--
This is an automated message from the Apache Git Service.
To respond to
Fokko merged PR #127:
URL: https://github.com/apache/iceberg-python/pull/127
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.
hussein-awala commented on PR #127:
URL: https://github.com/apache/iceberg-python/pull/127#issuecomment-1874338838
I just merged main and fixed the conflicts, it should be ready to merge.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on
rdblue commented on PR #127:
URL: https://github.com/apache/iceberg-python/pull/127#issuecomment-1874330644
Looks good to me now. Thanks, @hussein-awala!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
hussein-awala commented on PR #127:
URL: https://github.com/apache/iceberg-python/pull/127#issuecomment-1858928681
> @hussein-awala the PR has been merged :)
I was waiting for the release, the merged PR was released 3 days ago in
[v0.1.8](https://github.com/astral-sh/ruff/releases/tag
Fokko commented on PR #127:
URL: https://github.com/apache/iceberg-python/pull/127#issuecomment-1848662110
@hussein-awala the PR has been merged :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
hussein-awala commented on code in PR #127:
URL: https://github.com/apache/iceberg-python/pull/127#discussion_r1405455829
##
.pre-commit-config.yaml:
##
@@ -29,15 +29,11 @@ repos:
- id: check-ast
- repo: https://github.com/astral-sh/ruff-pre-commit
# Ruff version
hussein-awala commented on PR #127:
URL: https://github.com/apache/iceberg-python/pull/127#issuecomment-1826859402
> Looks fine overall, but it seems like too many changes with string
normalization. Why force string normalization? That's going to cause a ton of
pull requests to fail formatt
Fokko commented on code in PR #127:
URL: https://github.com/apache/iceberg-python/pull/127#discussion_r1382622265
##
.pre-commit-config.yaml:
##
@@ -29,15 +29,11 @@ repos:
- id: check-ast
- repo: https://github.com/astral-sh/ruff-pre-commit
# Ruff version (Used fo
rdblue commented on PR #127:
URL: https://github.com/apache/iceberg-python/pull/127#issuecomment-1793797091
Looks fine overall, but it seems like too many changes with string
normalization. Why force string normalization? That's going to cause a ton of
pull requests to fail formatting valid
hussein-awala opened a new pull request, #127:
URL: https://github.com/apache/iceberg-python/pull/127
This PR replaces black with Ruff Formatter, which is 30x faster
(https://astral.sh/blog/the-ruff-formatter). It also removes the
`--skip-string-normalization` config to replace single quote
11 matches
Mail list logo
