hussein-awala commented on PR #127: URL: https://github.com/apache/iceberg-python/pull/127#issuecomment-1858928681
> @hussein-awala the PR has been merged :) I was waiting for the release, the merged PR was released 3 days ago in [v0.1.8](https://github.com/astral-sh/ruff/releases/tag/v0.1.8) as a preview feature, for that I had to add `--preview` argument for `ruff` and `ruff-format`. > Looks fine overall, but it seems like too many changes with string normalization. Why force string normalization? That's going to cause a ton of pull requests to fail formatting validation. @rdblue could you check it now after changing `quote-style` to `preserve`? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org
