Re: [PR] Remove numpy as a hard dependency [iceberg-python]

2024-10-30 Thread via GitHub
corleyma commented on PR #1270: URL: https://github.com/apache/iceberg-python/pull/1270#issuecomment-2448396256 @kevinjqliu curious what y'all think of my comment here: https://github.com/apache/iceberg-python/issues/1259#issuecomment-2448393527 -- This is an automated message from the Ap

Re: [PR] Remove numpy as a hard dependency [iceberg-python]

2024-10-30 Thread via GitHub
Fokko merged PR #1270: URL: https://github.com/apache/iceberg-python/pull/1270 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceber

Re: [PR] Remove numpy as a hard dependency [iceberg-python]

2024-10-30 Thread via GitHub
Fokko commented on PR #1270: URL: https://github.com/apache/iceberg-python/pull/1270#issuecomment-2448010464 @kevinjqliu That's an excellent suggestion, I only created one on the Arrow side, thanks! -- This is an automated message from the Apache Git Service. To respond to the message, pl

Re: [PR] Remove numpy as a hard dependency [iceberg-python]

2024-10-30 Thread via GitHub
Fokko commented on code in PR #1270: URL: https://github.com/apache/iceberg-python/pull/1270#discussion_r1823175129 ## pyiceberg/io/pyarrow.py: ## @@ -812,7 +811,15 @@ def _combine_positional_deletes(positional_deletes: List[pa.ChunkedArray], start all_chunks = positio

[PR] Remove numpy as a hard dependency [iceberg-python]

2024-10-30 Thread via GitHub
Fokko opened a new pull request, #1270: URL: https://github.com/apache/iceberg-python/pull/1270 With Arrow 18.0.0 numpy is not a dependency anymore: https://github.com/apache/arrow/pull/44148 I think it would be good to remove it from PyIceberg. -- This is an automated message from