Fokko commented on code in PR #1270:
URL: https://github.com/apache/iceberg-python/pull/1270#discussion_r1823175129
##########
pyiceberg/io/pyarrow.py:
##########
@@ -812,7 +811,15 @@ def _combine_positional_deletes(positional_deletes:
List[pa.ChunkedArray], start
all_chunks = positional_deletes[0]
else:
all_chunks = pa.chunked_array(itertools.chain(*[arr.chunks for arr in
positional_deletes]))
- return np.subtract(np.setdiff1d(np.arange(start_index, end_index),
all_chunks, assume_unique=False), start_index)
+
+ # Create the full range array with pyarrow
+ full_range = pa.array(range(start_index, end_index))
Review Comment:
```suggestion
full_range = pa.array(range(start_index, end_index))
# When available, replace with Arrow generator to improve performance
# See https://github.com/apache/iceberg-python/issues/1271 for details
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
