Re: [PR] Remove deprecated methods from ContentCache [iceberg]

2024-06-14 Thread via GitHub
findepi closed pull request #10495: Remove deprecated methods from ContentCache URL: https://github.com/apache/iceberg/pull/10495 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

Re: [PR] Remove deprecated methods from ContentCache [iceberg]

2024-06-14 Thread via GitHub
szehon-ho commented on PR #10495: URL: https://github.com/apache/iceberg/pull/10495#issuecomment-2168763163 Yea Im not familiar with ContentCache but that is strange that return type is private..., yea in any case according to revapi we are breaking core compatibility. -- This is an auto

Re: [PR] Remove deprecated methods from ContentCache [iceberg]

2024-06-14 Thread via GitHub
findepi commented on PR #10495: URL: https://github.com/apache/iceberg/pull/10495#issuecomment-2168719835 @szehon-ho `public InputFile tryCache(FileIO io, String location, long length)` is indeed also deprecated, but strictly speaking, removing this method would be breaking iceberg-core api

Re: [PR] Remove deprecated methods from ContentCache [iceberg]

2024-06-14 Thread via GitHub
szehon-ho commented on PR #10495: URL: https://github.com/apache/iceberg/pull/10495#issuecomment-2168679498 How about removing the next one: public InputFile tryCache(FileIO io, String location, long length) ? -- This is an automated message from the Apache Git Service. To respond to the

[PR] Remove deprecated methods from ContentCache [iceberg]

2024-06-14 Thread via GitHub
findepi opened a new pull request, #10495: URL: https://github.com/apache/iceberg/pull/10495 They are deprecated, unused and not part of API. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the s