findepi commented on PR #10495:
URL: https://github.com/apache/iceberg/pull/10495#issuecomment-2168719835
@szehon-ho `public InputFile tryCache(FileIO io, String location, long
length)` is indeed also deprecated, but strictly speaking, removing this method
would be breaking iceberg-core api compatibility.
The difference is that this `tryCache` overload can be used, its return type
was public.
The methods removed here have private return type, so they weren't very
useful. However I realized they were still callable, for example someone could
write `contentCache.get("foo") != null`.
Is this the reason why they weren't immediately removed?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
