wypoon commented on PR #11661:
URL: https://github.com/apache/iceberg/pull/11661#issuecomment-2702853897
@amogh-jahagirdar can you please take a look?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
nastra commented on PR #11661:
URL: https://github.com/apache/iceberg/pull/11661#issuecomment-2637261564
@RussellSpitzer @amogh-jahagirdar @pvary could you take a look at this one
please?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log o
wypoon commented on PR #11661:
URL: https://github.com/apache/iceberg/pull/11661#issuecomment-2632893053
@nastra any chance of moving this forward?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
wypoon commented on PR #11661:
URL: https://github.com/apache/iceberg/pull/11661#issuecomment-2576017364
Hi @RussellSpitzer, I see that @nastra requested a review from you on this.
I believe he wants a second pair of eyes to check that the refactor is correct.
Can you please review?
--
wypoon commented on PR #11661:
URL: https://github.com/apache/iceberg/pull/11661#issuecomment-2550192120
@nastra ping.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To un
wypoon commented on PR #11661:
URL: https://github.com/apache/iceberg/pull/11661#issuecomment-2537946114
Hi @nastra, I have addressed your feedback last week. Can you please review
this again?
--
This is an automated message from the Apache Git Service.
To respond to the message, please l
wypoon commented on PR #11661:
URL: https://github.com/apache/iceberg/pull/11661#issuecomment-2513299002
@nastra thank you for reviewing this. I have done some renaming as you
suggested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on
wypoon commented on code in PR #11661:
URL: https://github.com/apache/iceberg/pull/11661#discussion_r1866764798
##
arrow/src/main/java/org/apache/iceberg/arrow/vectorized/parquet/VectorizedParquetDefinitionLevelReader.java:
##
@@ -46,122 +47,217 @@ public VectorizedParquetDefini
wypoon commented on code in PR #11661:
URL: https://github.com/apache/iceberg/pull/11661#discussion_r1866755885
##
arrow/src/main/java/org/apache/iceberg/arrow/vectorized/parquet/VectorizedParquetDefinitionLevelReader.java:
##
@@ -46,122 +47,217 @@ public VectorizedParquetDefini
wypoon commented on code in PR #11661:
URL: https://github.com/apache/iceberg/pull/11661#discussion_r1866757589
##
arrow/src/main/java/org/apache/iceberg/arrow/vectorized/parquet/VectorizedParquetDefinitionLevelReader.java:
##
@@ -46,122 +47,217 @@ public VectorizedParquetDefini
nastra commented on code in PR #11661:
URL: https://github.com/apache/iceberg/pull/11661#discussion_r1865502617
##
arrow/src/main/java/org/apache/iceberg/arrow/vectorized/parquet/VectorizedParquetDefinitionLevelReader.java:
##
@@ -46,122 +47,217 @@ public VectorizedParquetDefini
nastra commented on code in PR #11661:
URL: https://github.com/apache/iceberg/pull/11661#discussion_r1865498503
##
arrow/src/main/java/org/apache/iceberg/arrow/vectorized/parquet/VectorizedParquetDefinitionLevelReader.java:
##
@@ -46,122 +47,217 @@ public VectorizedParquetDefini
nastra commented on code in PR #11661:
URL: https://github.com/apache/iceberg/pull/11661#discussion_r1865497835
##
arrow/src/main/java/org/apache/iceberg/arrow/vectorized/parquet/VectorizedParquetDefinitionLevelReader.java:
##
@@ -46,122 +47,217 @@ public VectorizedParquetDefini
wypoon commented on PR #11661:
URL: https://github.com/apache/iceberg/pull/11661#issuecomment-2502493531
@nastra can you please review this?
My impetus for the refactor is that I want to implement Parquet
page-skipping, and with the refactor, a core change in logic can be applied in
one
wypoon commented on code in PR #11661:
URL: https://github.com/apache/iceberg/pull/11661#discussion_r1859480431
##
arrow/src/main/java/org/apache/iceberg/arrow/vectorized/parquet/VectorizedParquetDefinitionLevelReader.java:
##
@@ -46,122 +47,217 @@ public VectorizedParquetDefini
wypoon commented on code in PR #11661:
URL: https://github.com/apache/iceberg/pull/11661#discussion_r1859480431
##
arrow/src/main/java/org/apache/iceberg/arrow/vectorized/parquet/VectorizedParquetDefinitionLevelReader.java:
##
@@ -46,122 +47,217 @@ public VectorizedParquetDefini
16 matches
Mail list logo
