wypoon commented on code in PR #11661:
URL: https://github.com/apache/iceberg/pull/11661#discussion_r1866755885
##########
arrow/src/main/java/org/apache/iceberg/arrow/vectorized/parquet/VectorizedParquetDefinitionLevelReader.java:
##########
@@ -46,122 +47,217 @@ public VectorizedParquetDefinitionLevelReader(
super(bitWidth, maxDefLevel, readLength, setArrowValidityVector);
}
- abstract class NumericBaseReader {
- public void nextBatch(
+ abstract class CommonBaseReader {
+ protected void nextCommonBatch(
final FieldVector vector,
final int startOffset,
final int typeWidth,
final int numValsToRead,
NullabilityHolder nullabilityHolder,
- ValuesAsBytesReader valuesReader) {
- int bufferIdx = startOffset;
+ ValuesReader valuesReader,
+ Dictionary dict) {
+ int idx = startOffset;
int left = numValsToRead;
while (left > 0) {
if (currentCount == 0) {
readNextGroup();
}
int numValues = Math.min(left, currentCount);
+
+ byte[] byteArray = null;
+ if (typeWidth > -1) {
Review Comment:
That is correct. We initialize a byte array and it gets passed to
`nextRleBatch` and `nextPackedBatch`; these two methods are abstract and
overridden by `NumericBaseReader` and `BaseReader`; in `NumericBaseReader`,
these two methods simply ignore the `byteArray` that is passed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
