Re: [PR] REST: Use apache/iceberg-rest-fixture docker image [iceberg]

2024-12-17 Thread via GitHub
Fokko commented on PR #11673: URL: https://github.com/apache/iceberg/pull/11673#issuecomment-2547782519 @ajantha-bhat No, this looks great, it just fell off my radar :) Thanks for pinging me 👍 -- This is an automated message from the Apache Git Service. To respond to the message, please

Re: [PR] REST: Use apache/iceberg-rest-fixture docker image [iceberg]

2024-12-17 Thread via GitHub
Fokko merged PR #11673: URL: https://github.com/apache/iceberg/pull/11673 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apa

Re: [PR] REST: Use apache/iceberg-rest-fixture docker image [iceberg]

2024-12-12 Thread via GitHub
ajantha-bhat commented on PR #11673: URL: https://github.com/apache/iceberg/pull/11673#issuecomment-2538212669 @Fokko: Anything else needed for this PR? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [PR] REST: Use apache/iceberg-rest-fixture docker image [iceberg]

2024-12-09 Thread via GitHub
ajantha-bhat commented on PR #11673: URL: https://github.com/apache/iceberg/pull/11673#issuecomment-2530527622 Build has passed after changing the default URI to file based. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

Re: [PR] REST: Use apache/iceberg-rest-fixture docker image [iceberg]

2024-12-09 Thread via GitHub
ajantha-bhat commented on code in PR #11673: URL: https://github.com/apache/iceberg/pull/11673#discussion_r1876285651 ## kafka-connect/kafka-connect-runtime/docker/docker-compose.yml: ## @@ -50,6 +50,7 @@ services: environment: - AWS_REGION=us-east-1 - CATALOG

Re: [PR] REST: Use apache/iceberg-rest-fixture docker image [iceberg]

2024-12-09 Thread via GitHub
ajantha-bhat commented on code in PR #11673: URL: https://github.com/apache/iceberg/pull/11673#discussion_r1876285651 ## kafka-connect/kafka-connect-runtime/docker/docker-compose.yml: ## @@ -50,6 +50,7 @@ services: environment: - AWS_REGION=us-east-1 - CATALOG

Re: [PR] REST: Use apache/iceberg-rest-fixture docker image [iceberg]

2024-12-09 Thread via GitHub
ajantha-bhat commented on PR #11673: URL: https://github.com/apache/iceberg/pull/11673#issuecomment-2528510623 @Fokko: Thanks for running locally. Kafka connect checks passed now after adding catalog URI. -- This is an automated message from the Apache Git Service. To respond to the mes

Re: [PR] REST: Use apache/iceberg-rest-fixture docker image [iceberg]

2024-12-09 Thread via GitHub
Fokko commented on PR #11673: URL: https://github.com/apache/iceberg/pull/11673#issuecomment-2528160086 Hmm, that's too bad. Let me check if it works on my machine -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the UR

Re: [PR] REST: Use apache/iceberg-rest-fixture docker image [iceberg]

2024-12-09 Thread via GitHub
Fokko commented on PR #11673: URL: https://github.com/apache/iceberg/pull/11673#issuecomment-2528250190 @ajantha-bhat I noticed that the docker-container is very old, can you try: ``` --- a/kafka-connect/kafka-connect-runtime/docker/docker-compose.yml +++ b/kafka-connect/kafka-co

Re: [PR] REST: Use apache/iceberg-rest-fixture docker image [iceberg]

2024-12-09 Thread via GitHub
ajantha-bhat commented on PR #11673: URL: https://github.com/apache/iceberg/pull/11673#issuecomment-2528139454 @Fokko: The build is not passing. I figuring out :( Locally I can't run it (has some other error). That is why it is still in draft. -- This is an automated messa

Re: [PR] REST: Use apache/iceberg-rest-fixture docker image [iceberg]

2024-12-04 Thread via GitHub
ajantha-bhat closed pull request #11673: REST: Use apache/iceberg-rest-fixture docker image URL: https://github.com/apache/iceberg/pull/11673 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the spec

Re: [PR] REST: Use apache/iceberg-rest-fixture docker image [iceberg]

2024-12-04 Thread via GitHub
Fokko commented on PR #11673: URL: https://github.com/apache/iceberg/pull/11673#issuecomment-2517194949 @ajantha-bhat Go for it 🚀 https://hub.docker.com/repository/docker/apache/iceberg-rest-fixture/general -- This is an automated message from the Apache Git Service. To respond to the me

Re: [PR] REST: Use apache/iceberg-rest-fixture docker image [iceberg]

2024-12-04 Thread via GitHub
ajantha-bhat commented on PR #11673: URL: https://github.com/apache/iceberg/pull/11673#issuecomment-2517151164 @Fokko: Thanks for pinged on the infra ticket, I saw that repo is created now 👍 I will rebase/retrigger this PR once we publish our docker image. -- This is an automate

Re: [PR] REST: Use apache/iceberg-rest-fixture docker image [iceberg]

2024-12-04 Thread via GitHub
Fokko commented on PR #11673: URL: https://github.com/apache/iceberg/pull/11673#issuecomment-2516576543 Pinged INFRA on the [ticket](https://issues.apache.org/jira/browse/INFRA-26275). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

Re: [PR] REST: Use apache/iceberg-rest-fixture docker image [iceberg]

2024-11-29 Thread via GitHub
Fokko commented on PR #11673: URL: https://github.com/apache/iceberg/pull/11673#issuecomment-2507538087 @ajantha-bhat Should we split out the renaming into a separate PR? I think it would be good to get that cleaned up ASAP. We can combine the rename with decoupling the user and the reposit

Re: [PR] REST: Use apache/iceberg-rest-fixture docker image [iceberg]

2024-11-29 Thread via GitHub
ajantha-bhat commented on PR #11673: URL: https://github.com/apache/iceberg/pull/11673#issuecomment-2507462690 waiting to publish image first to the dockerhub -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL abo