Fokko commented on PR #11673: URL: https://github.com/apache/iceberg/pull/11673#issuecomment-2507538087
@ajantha-bhat Should we split out the renaming into a separate PR? I think it would be good to get that cleaned up ASAP. We can combine the rename with decoupling the user and the repository: https://github.com/apache/iceberg/blob/7c7b4bac9097217f5563338dbc4b30d1559b5d76/.github/workflows/publish-docker.yml#L51-L55 We want to set the repository to `apache` instead of the user. If you're using a personal dockerhub account the username and the repository are the same, if you're using an organization, they are different. I think as part of the naming, we should also include `iceberg-rest-fixtures` in the name of the action: https://github.com/apache/iceberg/blob/7c7b4bac9097217f5563338dbc4b30d1559b5d76/.github/workflows/publish-docker.yml#L20 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org
