zeroshade commented on code in PR #276:
URL: https://github.com/apache/iceberg-go/pull/276#discussion_r1934565005
##
catalog/registry.go:
##
@@ -64,13 +65,13 @@ var (
// Registrar is a factory for creating Catalog instances, used for registering
to use
// with LoadCatalog.
t
curtisr7 commented on code in PR #276:
URL: https://github.com/apache/iceberg-go/pull/276#discussion_r1933056167
##
catalog/glue/glue.go:
##
@@ -69,7 +69,7 @@ var (
func init() {
catalog.Register("glue", catalog.RegistrarFunc(func(_ string, props
iceberg.Properties)
zeroshade commented on code in PR #276:
URL: https://github.com/apache/iceberg-go/pull/276#discussion_r1932887872
##
catalog/rest/rest.go:
##
@@ -82,7 +82,7 @@ var (
func init() {
reg := catalog.RegistrarFunc(func(name string, p iceberg.Properties)
(catalog.Catalog,
zeroshade commented on code in PR #276:
URL: https://github.com/apache/iceberg-go/pull/276#discussion_r1932886875
##
catalog/glue/glue.go:
##
@@ -69,7 +69,7 @@ var (
func init() {
catalog.Register("glue", catalog.RegistrarFunc(func(_ string, props
iceberg.Properties)
curtisr7 opened a new pull request, #276:
URL: https://github.com/apache/iceberg-go/pull/276
In general we should pass `context.Context` through call path rather than
creating `context.Background` at random places.
I made this change in response to [this
comment](https://github.com/a
