zeroshade commented on code in PR #276:
URL: https://github.com/apache/iceberg-go/pull/276#discussion_r1934565005
##########
catalog/registry.go:
##########
@@ -64,13 +65,13 @@ var (
// Registrar is a factory for creating Catalog instances, used for registering
to use
// with LoadCatalog.
type Registrar interface {
- GetCatalog(catalogURI string, props iceberg.Properties) (Catalog, error)
+ GetCatalog(ctx context.Context, catalogURI string, props
iceberg.Properties) (Catalog, error)
}
-type RegistrarFunc func(string, iceberg.Properties) (Catalog, error)
+type RegistrarFunc func(context.Context, string, iceberg.Properties) (Catalog,
error)
-func (f RegistrarFunc) GetCatalog(catalogURI string, props iceberg.Properties)
(Catalog, error) {
- return f(catalogURI, props)
+func (f RegistrarFunc) GetCatalog(ctx context.Context, catalogURI string,
props iceberg.Properties) (Catalog, error) {
Review Comment:
same as above
##########
catalog/registry.go:
##########
@@ -64,13 +65,13 @@ var (
// Registrar is a factory for creating Catalog instances, used for registering
to use
// with LoadCatalog.
type Registrar interface {
- GetCatalog(catalogURI string, props iceberg.Properties) (Catalog, error)
+ GetCatalog(ctx context.Context, catalogURI string, props
iceberg.Properties) (Catalog, error)
Review Comment:
we should update this, the `catalogURI` param should be renamed
`catalogName` based on the updated semantics
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
