Re: [PR] Plaintext length in GCM Input Streams [iceberg]

2024-02-28 Thread via GitHub
ggershinsky closed pull request #9752: Plaintext length in GCM Input Streams URL: https://github.com/apache/iceberg/pull/9752 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

Re: [PR] Plaintext length in GCM Input Streams [iceberg]

2024-02-28 Thread via GitHub
ggershinsky commented on PR #9752: URL: https://github.com/apache/iceberg/pull/9752#issuecomment-1968923124 Per the discussion, we'll add a method `storedLength` to the `PositionOutputStream`. No plaintext length will be used, closing this PR. -- This is an automated message from the Apac

Re: [PR] Plaintext length in GCM Input Streams [iceberg]

2024-02-26 Thread via GitHub
ggershinsky commented on code in PR #9752: URL: https://github.com/apache/iceberg/pull/9752#discussion_r1502705557 ## core/src/main/java/org/apache/iceberg/encryption/AesGcmInputFile.java: ## @@ -20,39 +20,33 @@ import org.apache.iceberg.io.InputFile; import org.apache.icebe

Re: [PR] Plaintext length in GCM Input Streams [iceberg]

2024-02-26 Thread via GitHub
ggershinsky commented on code in PR #9752: URL: https://github.com/apache/iceberg/pull/9752#discussion_r1502719019 ## core/src/main/java/org/apache/iceberg/encryption/AesGcmInputFile.java: ## @@ -20,39 +20,33 @@ import org.apache.iceberg.io.InputFile; import org.apache.icebe

Re: [PR] Plaintext length in GCM Input Streams [iceberg]

2024-02-26 Thread via GitHub
ggershinsky commented on code in PR #9752: URL: https://github.com/apache/iceberg/pull/9752#discussion_r1502705557 ## core/src/main/java/org/apache/iceberg/encryption/AesGcmInputFile.java: ## @@ -20,39 +20,33 @@ import org.apache.iceberg.io.InputFile; import org.apache.icebe

Re: [PR] Plaintext length in GCM Input Streams [iceberg]

2024-02-25 Thread via GitHub
rdblue commented on code in PR #9752: URL: https://github.com/apache/iceberg/pull/9752#discussion_r1501944749 ## core/src/main/java/org/apache/iceberg/encryption/AesGcmInputFile.java: ## @@ -20,39 +20,33 @@ import org.apache.iceberg.io.InputFile; import org.apache.iceberg.io

Re: [PR] Plaintext length in GCM Input Streams [iceberg]

2024-02-25 Thread via GitHub
rdblue commented on code in PR #9752: URL: https://github.com/apache/iceberg/pull/9752#discussion_r1501944749 ## core/src/main/java/org/apache/iceberg/encryption/AesGcmInputFile.java: ## @@ -20,39 +20,33 @@ import org.apache.iceberg.io.InputFile; import org.apache.iceberg.io

Re: [PR] Plaintext length in GCM Input Streams [iceberg]

2024-02-25 Thread via GitHub
rdblue commented on code in PR #9752: URL: https://github.com/apache/iceberg/pull/9752#discussion_r1501943394 ## core/src/main/java/org/apache/iceberg/encryption/AesGcmInputFile.java: ## @@ -20,39 +20,33 @@ import org.apache.iceberg.io.InputFile; import org.apache.iceberg.io

Re: [PR] Plaintext length in GCM Input Streams [iceberg]

2024-02-21 Thread via GitHub
ggershinsky commented on code in PR #9752: URL: https://github.com/apache/iceberg/pull/9752#discussion_r1497429004 ## core/src/main/java/org/apache/iceberg/encryption/AesGcmInputFile.java: ## @@ -20,39 +20,33 @@ import org.apache.iceberg.io.InputFile; import org.apache.icebe

Re: [PR] Plaintext length in GCM Input Streams [iceberg]

2024-02-20 Thread via GitHub
ggershinsky commented on code in PR #9752: URL: https://github.com/apache/iceberg/pull/9752#discussion_r1496995688 ## api/src/main/java/org/apache/iceberg/Files.java: ## @@ -95,26 +95,40 @@ public String toString() { } public static InputFile localInput(File file) { -

Re: [PR] Plaintext length in GCM Input Streams [iceberg]

2024-02-20 Thread via GitHub
rdblue commented on code in PR #9752: URL: https://github.com/apache/iceberg/pull/9752#discussion_r1496240901 ## core/src/main/java/org/apache/iceberg/encryption/AesGcmInputFile.java: ## @@ -20,39 +20,33 @@ import org.apache.iceberg.io.InputFile; import org.apache.iceberg.io

Re: [PR] Plaintext length in GCM Input Streams [iceberg]

2024-02-20 Thread via GitHub
rdblue commented on code in PR #9752: URL: https://github.com/apache/iceberg/pull/9752#discussion_r1496240901 ## core/src/main/java/org/apache/iceberg/encryption/AesGcmInputFile.java: ## @@ -20,39 +20,33 @@ import org.apache.iceberg.io.InputFile; import org.apache.iceberg.io

Re: [PR] Plaintext length in GCM Input Streams [iceberg]

2024-02-20 Thread via GitHub
rdblue commented on code in PR #9752: URL: https://github.com/apache/iceberg/pull/9752#discussion_r1496238941 ## api/src/main/java/org/apache/iceberg/Files.java: ## @@ -95,26 +95,40 @@ public String toString() { } public static InputFile localInput(File file) { -retu