rdblue commented on code in PR #9752:
URL: https://github.com/apache/iceberg/pull/9752#discussion_r1496238941
##########
api/src/main/java/org/apache/iceberg/Files.java:
##########
@@ -95,26 +95,40 @@ public String toString() {
}
public static InputFile localInput(File file) {
- return new LocalInputFile(file);
+ return new LocalInputFile(file, -1L);
+ }
+
+ public static InputFile localInput(File file, long length) {
+ return new LocalInputFile(file, length);
}
public static InputFile localInput(String file) {
+ return localInput(file, -1L);
Review Comment:
I don't think it is a good idea to use -1. Can you refactor so that it isn't
required?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
