zhongyujiang commented on PR #10090:
URL: https://github.com/apache/iceberg/pull/10090#issuecomment-2436873425
Hey @amogh-jahagirdar @Fokko @nastra @danielcweeks, can you help review this
when you have time? Thanks
--
This is an automated message from the Apache Git Service.
To respond to
github-actions[bot] commented on PR #10090:
URL: https://github.com/apache/iceberg/pull/10090#issuecomment-2436555213
This pull request has been marked as stale due to 30 days of inactivity. It
will be closed in 1 week if no further activity occurs. If you think that’s
incorrect or this pul
amogh-jahagirdar commented on code in PR #10090:
URL: https://github.com/apache/iceberg/pull/10090#discussion_r1640408646
##
parquet/src/main/java/org/apache/iceberg/parquet/ParquetDictionaryRowGroupFilter.java:
##
@@ -116,48 +122,48 @@ private boolean eval(
}
}
zhongyujiang commented on code in PR #10090:
URL: https://github.com/apache/iceberg/pull/10090#discussion_r1634617829
##
parquet/src/main/java/org/apache/iceberg/parquet/ParquetBloomRowGroupFilter.java:
##
@@ -290,7 +299,7 @@ private boolean shouldRead(
hashValue
amogh-jahagirdar commented on PR #10090:
URL: https://github.com/apache/iceberg/pull/10090#issuecomment-2157401562
@zhongyujiang I'm really sorry for the delayed review on my part. I think
this is an important improvement!
I will be taking a deeper look at the implementation this wee
Fokko commented on code in PR #10090:
URL: https://github.com/apache/iceberg/pull/10090#discussion_r1631916500
##
parquet/src/main/java/org/apache/iceberg/parquet/ParquetBloomRowGroupFilter.java:
##
@@ -290,7 +299,7 @@ private boolean shouldRead(
hashValue = bloo
zhongyujiang commented on PR #6893:
URL: https://github.com/apache/iceberg/pull/6893#issuecomment-2041294392
Replaced by #10090.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comme
zhongyujiang closed pull request #6893: Parquet: Make row-group filters
cooperate to filter
URL: https://github.com/apache/iceberg/pull/6893
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the speci
zhongyujiang opened a new pull request, #10090:
URL: https://github.com/apache/iceberg/pull/10090
This PR refactors three Parquet row-group filters into a form that computes
residual expressions, allowing it to return a residual expression for the given
row-groups. The residual computed by
cccs-jc commented on PR #6893:
URL: https://github.com/apache/iceberg/pull/6893#issuecomment-2037778990
It would be great to revive your PR. I think it's the best approach and it's
a major improvement over the current implementation. The query speed is much
faster with this fix.
I ha
zhongyujiang commented on PR #6893:
URL: https://github.com/apache/iceberg/pull/6893#issuecomment-2035906920
> any reason why you stopped pursuing it?
There was relatively little feedback from the community after openning this
PR, so I did not proceed with it further. Since more peo
cccs-jc commented on PR #6893:
URL: https://github.com/apache/iceberg/pull/6893#issuecomment-2035231045
I'm interested in getting that PR into the upstream Iceberg. @zhongyujiang
any reason why you stopped pursuing it? Are you using it in production?
--
This is an automated message from t
12 matches
Mail list logo
