zhongyujiang commented on code in PR #10090:
URL: https://github.com/apache/iceberg/pull/10090#discussion_r1634617829
##########
parquet/src/main/java/org/apache/iceberg/parquet/ParquetBloomRowGroupFilter.java:
##########
@@ -290,7 +299,7 @@ private <T> boolean shouldRead(
hashValue = bloom.hash(((Number) value).intValue());
return bloom.findHash(hashValue);
default:
- return ROWS_MIGHT_MATCH;
+ return true;
Review Comment:
This is because the types of these two constants have been changed from
`boolean` to the generic class `Expression` of
[`FindsResidualVisitor`](https://github.com/apache/iceberg/pull/10090/files#diff-0fcc434085226037ca86087d4ed36984b30def152e4649b2adcc352f16d15f31).
For readability, maybe we can add a comment after the boolean value ?
```java
return true; /* rows might match */
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
