Re: [PR] Parquet: Implement defaults for generic data [iceberg]

2024-12-16 Thread via GitHub
rdblue commented on PR #11785: URL: https://github.com/apache/iceberg/pull/11785#issuecomment-2546711840 Merging this. Thanks for the review, @Fokko! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

Re: [PR] Parquet: Implement defaults for generic data [iceberg]

2024-12-16 Thread via GitHub
rdblue merged PR #11785: URL: https://github.com/apache/iceberg/pull/11785 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.ap

Re: [PR] Parquet: Implement defaults for generic data [iceberg]

2024-12-16 Thread via GitHub
rdblue commented on code in PR #11785: URL: https://github.com/apache/iceberg/pull/11785#discussion_r1887254859 ## data/src/test/java/org/apache/iceberg/data/parquet/TestGenericData.java: ## @@ -131,14 +136,143 @@ public void testTwoLevelList() throws IOException {

Re: [PR] Parquet: Implement defaults for generic data [iceberg]

2024-12-16 Thread via GitHub
rdblue commented on code in PR #11785: URL: https://github.com/apache/iceberg/pull/11785#discussion_r1887251904 ## data/src/test/java/org/apache/iceberg/data/parquet/TestGenericData.java: ## @@ -131,14 +136,143 @@ public void testTwoLevelList() throws IOException {

Re: [PR] Parquet: Implement defaults for generic data [iceberg]

2024-12-16 Thread via GitHub
rdblue commented on code in PR #11785: URL: https://github.com/apache/iceberg/pull/11785#discussion_r1887250072 ## data/src/test/java/org/apache/iceberg/data/parquet/TestGenericData.java: ## @@ -131,14 +136,143 @@ public void testTwoLevelList() throws IOException {

Re: [PR] Parquet: Implement defaults for generic data [iceberg]

2024-12-15 Thread via GitHub
emkornfield commented on code in PR #11785: URL: https://github.com/apache/iceberg/pull/11785#discussion_r1886202200 ## data/src/test/java/org/apache/iceberg/data/parquet/TestGenericData.java: ## @@ -131,14 +136,143 @@ public void testTwoLevelList() throws IOException {

Re: [PR] Parquet: Implement defaults for generic data [iceberg]

2024-12-15 Thread via GitHub
emkornfield commented on code in PR #11785: URL: https://github.com/apache/iceberg/pull/11785#discussion_r1886202200 ## data/src/test/java/org/apache/iceberg/data/parquet/TestGenericData.java: ## @@ -131,14 +136,143 @@ public void testTwoLevelList() throws IOException {

Re: [PR] Parquet: Implement defaults for generic data [iceberg]

2024-12-15 Thread via GitHub
Fokko commented on code in PR #11785: URL: https://github.com/apache/iceberg/pull/11785#discussion_r1885729020 ## data/src/test/java/org/apache/iceberg/data/parquet/TestGenericData.java: ## @@ -131,14 +136,143 @@ public void testTwoLevelList() throws IOException { .