tbaeg commented on PR #11895:
URL: https://github.com/apache/iceberg/pull/11895#issuecomment-2588475018
I think incremental improvement for the existing implementation (even if
slated for rewrite) should be included.
Of note, we cherry-picked commits from
https://github.com/apache/ic
shanielh closed pull request #11895: ParallelIterable: Queue Size w/ O(1)
URL: https://github.com/apache/iceberg/pull/11895
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To u
RussellSpitzer commented on PR #11895:
URL: https://github.com/apache/iceberg/pull/11895#issuecomment-2587582525
> @RussellSpitzer, I see that #11768 is closed now, we use the PR in a
forked version for over a week now and we've observed no issues, any chance to
merge this? BTW, the fix for
shanielh commented on PR #11895:
URL: https://github.com/apache/iceberg/pull/11895#issuecomment-2586412692
@RussellSpitzer, I see that #11768 is closed now, we use the PR in a forked
version for over a week now and we've observed no issues, any chance to merge
this? BTW, the fix for #11768
shanielh commented on PR #11895:
URL: https://github.com/apache/iceberg/pull/11895#issuecomment-2568987952
> I wonder if this is as important if we switch ParallelIterable to use the
implementation suggested here https://github.com/apache/iceberg/issues/11768
which limits the queue depth si
RussellSpitzer commented on PR #11895:
URL: https://github.com/apache/iceberg/pull/11895#issuecomment-2568194825
I wonder if this is as important if we switch ParallelIterable to use the
implementation suggested here https://github.com/apache/iceberg/issues/11768
which limits the queue dept
shanielh commented on PR #11895:
URL: https://github.com/apache/iceberg/pull/11895#issuecomment-2566977078
> LGTM as well ! Thank you for the fix !
>
> > have a JFR dump that shows this method uses 35% CPU utilization, this
> > is why I think this commit is important
>
> inte
shanielh opened a new pull request, #11895:
URL: https://github.com/apache/iceberg/pull/11895
Instead of using ConcurrentLinkedQueue.size() which runs over the Linked
Queue
in order to get the size of the queue, manage an AtomicInteger with the size
of the queue.
ConcurrentLinke
