RussellSpitzer commented on PR #11895: URL: https://github.com/apache/iceberg/pull/11895#issuecomment-2587582525
> @RussellSpitzer, I see that #11768 is closed now, we use the PR in a forked version for over a week now and we've observed no issues, any chance to merge this? BTW, the fix for #11768 added another usage of `queue.size()` which is highly not recommended for concurrent applications, so the state would be even less optimal now, I can rebase if needed. As I mentioned before, 11768 reduces the number of calls to queue.size() from O(number of elements) to O(number of files) by moving the check out of the hot path so size() should now be drastically reduced in the number of times it is actually called. Because of this I'm not sure this PR is actually required anymore but it still probably makes sense from a best practices prospective. That said I really would like us to work on a full rework (as I note here https://github.com/apache/iceberg/pull/11781#issuecomment-2569914295 ) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org
