Fokko merged PR #12010:
URL: https://github.com/apache/iceberg/pull/12010
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apa
Fokko commented on PR #12010:
URL: https://github.com/apache/iceberg/pull/12010#issuecomment-2615576044
The vote has been passed, I'll go ahead and merge this:
https://lists.apache.org/thread/sldl91pkb4pwzd88s06l0c6gr21qlrv7 Thanks
everyone and @c-thiel in particular! 🙌
--
This is an au
c-thiel commented on code in PR #12010:
URL: https://github.com/apache/iceberg/pull/12010#discussion_r1924816978
##
api/src/main/java/org/apache/iceberg/UpdateStatistics.java:
##
@@ -27,9 +27,22 @@ public interface UpdateStatistics extends
PendingUpdate> {
* the snapshot if
kevinjqliu commented on code in PR #12010:
URL: https://github.com/apache/iceberg/pull/12010#discussion_r1924096208
##
api/src/main/java/org/apache/iceberg/UpdateStatistics.java:
##
@@ -27,9 +27,22 @@ public interface UpdateStatistics extends
PendingUpdate> {
* the snapshot
nastra commented on PR #12010:
URL: https://github.com/apache/iceberg/pull/12010#issuecomment-2602652236
> @nastra ready for another round. Do we need a Vote on this in the Mailing
List?
Yes I think we should have a quick formal vote so that people are aware of
this change
--
This
c-thiel commented on PR #12010:
URL: https://github.com/apache/iceberg/pull/12010#issuecomment-2602554274
@nastra ready for another round
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the speci
c-thiel commented on code in PR #12010:
URL: https://github.com/apache/iceberg/pull/12010#discussion_r1922478361
##
api/src/main/java/org/apache/iceberg/UpdateStatistics.java:
##
@@ -27,9 +27,21 @@ public interface UpdateStatistics extends
PendingUpdate> {
* the snapshot if
nastra commented on code in PR #12010:
URL: https://github.com/apache/iceberg/pull/12010#discussion_r1922452079
##
open-api/rest-catalog-open-api.yaml:
##
@@ -2890,6 +2889,9 @@ components:
snapshot-id:
type: integer
format: int64
+ descrip
nastra commented on code in PR #12010:
URL: https://github.com/apache/iceberg/pull/12010#discussion_r1922450306
##
core/src/main/java/org/apache/iceberg/SetStatistics.java:
##
@@ -32,10 +32,22 @@ public SetStatistics(TableOperations ops) {
this.ops = ops;
}
+ /**
+
nastra commented on code in PR #12010:
URL: https://github.com/apache/iceberg/pull/12010#discussion_r1922449906
##
api/src/main/java/org/apache/iceberg/UpdateStatistics.java:
##
@@ -27,9 +27,21 @@ public interface UpdateStatistics extends
PendingUpdate> {
* the snapshot if
c-thiel commented on code in PR #12010:
URL: https://github.com/apache/iceberg/pull/12010#discussion_r1922444549
##
.palantir/revapi.yml:
##
@@ -1146,6 +1146,10 @@ acceptedBreaks:
\ org.apache.iceberg.TableMetadata)"
justification: "Removing deprecated code"
"
c-thiel commented on code in PR #12010:
URL: https://github.com/apache/iceberg/pull/12010#discussion_r1922443957
##
core/src/main/java/org/apache/iceberg/SetStatistics.java:
##
@@ -32,10 +32,22 @@ public SetStatistics(TableOperations ops) {
this.ops = ops;
}
+ /**
+
nastra commented on code in PR #12010:
URL: https://github.com/apache/iceberg/pull/12010#discussion_r1922281480
##
core/src/main/java/org/apache/iceberg/SetStatistics.java:
##
@@ -32,10 +32,22 @@ public SetStatistics(TableOperations ops) {
this.ops = ops;
}
+ /**
+
nastra commented on code in PR #12010:
URL: https://github.com/apache/iceberg/pull/12010#discussion_r1922280079
##
.palantir/revapi.yml:
##
@@ -1146,6 +1146,10 @@ acceptedBreaks:
\ org.apache.iceberg.TableMetadata)"
justification: "Removing deprecated code"
"1
nastra commented on code in PR #12010:
URL: https://github.com/apache/iceberg/pull/12010#discussion_r1922279411
##
api/src/main/java/org/apache/iceberg/UpdateStatistics.java:
##
@@ -27,9 +27,19 @@ public interface UpdateStatistics extends
PendingUpdate> {
* the snapshot if
15 matches
Mail list logo
