kevinjqliu commented on code in PR #12010:
URL: https://github.com/apache/iceberg/pull/12010#discussion_r1924096208
##########
api/src/main/java/org/apache/iceberg/UpdateStatistics.java:
##########
@@ -27,9 +27,22 @@ public interface UpdateStatistics extends
PendingUpdate<List<StatisticsFile>> {
* the snapshot if any exists.
*
* @return this for method chaining
+ * @deprecated since 1.8.0, will be removed 1.9.0 or 2.0.0, use {@link
+ * #setStatistics(StatisticsFile)}.
*/
+ @Deprecated
UpdateStatistics setStatistics(long snapshotId, StatisticsFile
statisticsFile);
+ /**
+ * Set the table's statistics file for given snapshot, replacing the
previous statistics file for
+ * the snapshot if any exists.
+ *
+ * @return this for method chaining
+ */
Review Comment:
nit: should we mention in the docstring that the snapshot id is coming from
the statistics file?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
