nastra merged PR #8857:
URL: https://github.com/apache/iceberg/pull/8857
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apac
nastra commented on code in PR #8857:
URL: https://github.com/apache/iceberg/pull/8857#discussion_r1417446745
##
nessie/src/test/java/org/apache/iceberg/nessie/TestNessieIcebergClient.java:
##
@@ -91,15 +113,444 @@ public void testWithReferenceAfterRecreatingBranch()
Assert
nastra commented on code in PR #8857:
URL: https://github.com/apache/iceberg/pull/8857#discussion_r1417126334
##
nessie/src/test/java/org/apache/iceberg/nessie/TestMultipleClients.java:
##
@@ -67,33 +71,84 @@ public void afterEach() throws Exception {
}
@Test
- public v
dimas-b commented on code in PR #8857:
URL: https://github.com/apache/iceberg/pull/8857#discussion_r1415657426
##
nessie/src/test/java/org/apache/iceberg/nessie/TestMultipleClients.java:
##
@@ -67,33 +71,84 @@ public void afterEach() throws Exception {
}
@Test
- public
ajantha-bhat commented on PR #8857:
URL: https://github.com/apache/iceberg/pull/8857#issuecomment-1840534246
@nastra: Please help in merging this. I will rebase my view PR once this is
merged.
--
This is an automated message from the Apache Git Service.
To respond to the message, please
snazy commented on code in PR #8857:
URL: https://github.com/apache/iceberg/pull/8857#discussion_r1410786552
##
nessie/src/test/java/org/apache/iceberg/nessie/TestMultipleClients.java:
##
@@ -67,33 +71,84 @@ public void afterEach() throws Exception {
}
@Test
- public vo
snazy commented on code in PR #8857:
URL: https://github.com/apache/iceberg/pull/8857#discussion_r1410760088
##
nessie/src/main/java/org/apache/iceberg/nessie/NessieIcebergClient.java:
##
@@ -323,28 +417,13 @@ public void renameTable(TableIdentifier from,
TableIdentifier to) {
adutra commented on code in PR #8857:
URL: https://github.com/apache/iceberg/pull/8857#discussion_r1404580031
##
nessie/src/main/java/org/apache/iceberg/nessie/NessieIcebergClient.java:
##
@@ -181,133 +186,206 @@ public IcebergTable table(TableIdentifier
tableIdentifier) {
}
adutra commented on code in PR #8857:
URL: https://github.com/apache/iceberg/pull/8857#discussion_r1404533616
##
nessie/src/test/java/org/apache/iceberg/nessie/TestMultipleClients.java:
##
@@ -67,33 +71,84 @@ public void afterEach() throws Exception {
}
@Test
- public v
adutra commented on code in PR #8857:
URL: https://github.com/apache/iceberg/pull/8857#discussion_r1404449824
##
nessie/src/main/java/org/apache/iceberg/nessie/NessieIcebergClient.java:
##
@@ -181,133 +186,206 @@ public IcebergTable table(TableIdentifier
tableIdentifier) {
}
nastra commented on code in PR #8857:
URL: https://github.com/apache/iceberg/pull/8857#discussion_r1404431932
##
nessie/src/main/java/org/apache/iceberg/nessie/NessieIcebergClient.java:
##
@@ -181,133 +186,206 @@ public IcebergTable table(TableIdentifier
tableIdentifier) {
}
nastra commented on code in PR #8857:
URL: https://github.com/apache/iceberg/pull/8857#discussion_r1404430568
##
nessie/src/test/java/org/apache/iceberg/nessie/TestMultipleClients.java:
##
@@ -78,10 +81,19 @@ public void testListNamespaces() {
Assertions.assertThat(catalo
adutra commented on code in PR #8857:
URL: https://github.com/apache/iceberg/pull/8857#discussion_r1404403854
##
nessie/src/test/java/org/apache/iceberg/nessie/TestMultipleClients.java:
##
@@ -78,10 +81,19 @@ public void testListNamespaces() {
Assertions.assertThat(catalo
adutra commented on code in PR #8857:
URL: https://github.com/apache/iceberg/pull/8857#discussion_r1404380359
##
nessie/src/main/java/org/apache/iceberg/nessie/NessieIcebergClient.java:
##
@@ -181,133 +186,206 @@ public IcebergTable table(TableIdentifier
tableIdentifier) {
}
snazy commented on code in PR #8857:
URL: https://github.com/apache/iceberg/pull/8857#discussion_r1403377308
##
nessie/src/main/java/org/apache/iceberg/nessie/NessieIcebergClient.java:
##
@@ -181,133 +186,206 @@ public IcebergTable table(TableIdentifier
tableIdentifier) {
}
adutra commented on PR #8857:
URL: https://github.com/apache/iceberg/pull/8857#issuecomment-1823031640
I took the time to investigate what it would take to use the client-side
classes consistently. My final opinion is that it's not a good solution, for
the below reasons:
* Client-sid
dimas-b commented on PR #8857:
URL: https://github.com/apache/iceberg/pull/8857#issuecomment-1819117195
I'm fine with using `ClientSide*` builders for Namespace manipulation.
However, are we not getting the benefit of refactoring catalog code to be
more concise and straight-forward by
snazy commented on PR #8857:
URL: https://github.com/apache/iceberg/pull/8857#issuecomment-1816194902
> We would also be missing the commit meta specificities, which is the
primary reason for this change.
That functionality [exists in the client-side
implementation](https://github.co
adutra commented on PR #8857:
URL: https://github.com/apache/iceberg/pull/8857#issuecomment-1815978613
> I'd prefer to avoid duplicating the functionality that already exists in
`org.projectnessie.client.api.ns.ClientSide*Namespace`.
That is not at all what was decided
[here](https:
snazy commented on code in PR #8857:
URL: https://github.com/apache/iceberg/pull/8857#discussion_r1365303813
##
nessie/src/main/java/org/apache/iceberg/nessie/NessieIcebergClient.java:
##
@@ -223,27 +284,57 @@ namespace, getRef().getName()),
}
public boolean dropNamespac
adutra commented on code in PR #8857:
URL: https://github.com/apache/iceberg/pull/8857#discussion_r1392599014
##
nessie/src/main/java/org/apache/iceberg/nessie/NessieIcebergClient.java:
##
@@ -540,4 +585,64 @@ public void close() {
api.close();
}
}
+
+ private vo
nastra commented on code in PR #8857:
URL: https://github.com/apache/iceberg/pull/8857#discussion_r1392591040
##
nessie/src/main/java/org/apache/iceberg/nessie/NessieIcebergClient.java:
##
@@ -540,4 +585,64 @@ public void close() {
api.close();
}
}
+
+ private vo
adutra commented on code in PR #8857:
URL: https://github.com/apache/iceberg/pull/8857#discussion_r1392574413
##
nessie/src/main/java/org/apache/iceberg/nessie/NessieIcebergClient.java:
##
@@ -540,4 +585,64 @@ public void close() {
api.close();
}
}
+
+ private vo
nastra commented on code in PR #8857:
URL: https://github.com/apache/iceberg/pull/8857#discussion_r1392557462
##
nessie/src/main/java/org/apache/iceberg/nessie/NessieIcebergClient.java:
##
@@ -540,4 +585,64 @@ public void close() {
api.close();
}
}
+
+ private vo
adutra commented on code in PR #8857:
URL: https://github.com/apache/iceberg/pull/8857#discussion_r1392554187
##
nessie/src/test/java/org/apache/iceberg/nessie/TestNessieIcebergClient.java:
##
@@ -91,6 +111,412 @@ public void testWithReferenceAfterRecreatingBranch()
Asserti
nastra commented on code in PR #8857:
URL: https://github.com/apache/iceberg/pull/8857#discussion_r1392081563
##
nessie/src/test/java/org/apache/iceberg/nessie/TestNessieIcebergClient.java:
##
@@ -91,6 +111,412 @@ public void testWithReferenceAfterRecreatingBranch()
Asserti
nastra commented on code in PR #8857:
URL: https://github.com/apache/iceberg/pull/8857#discussion_r1392080692
##
nessie/src/main/java/org/apache/iceberg/nessie/NessieIcebergClient.java:
##
@@ -540,4 +585,64 @@ public void close() {
api.close();
}
}
+
+ private vo
adutra commented on PR #8857:
URL: https://github.com/apache/iceberg/pull/8857#issuecomment-1805861658
> @adutra have you checked whether all of these changes are still working
with the Nessie integration in Trino/Presto?
Just executed all tests in
`io.trino.plugin.iceberg.catalog.ne
adutra commented on code in PR #8857:
URL: https://github.com/apache/iceberg/pull/8857#discussion_r1389395174
##
nessie/src/main/java/org/apache/iceberg/nessie/NessieIcebergClient.java:
##
@@ -181,133 +186,220 @@ public IcebergTable table(TableIdentifier
tableIdentifier) {
}
nastra commented on PR #8857:
URL: https://github.com/apache/iceberg/pull/8857#issuecomment-1805311895
@adutra have you checked whether all of these changes are still working with
the Nessie integration in Trino/Presto?
--
This is an automated message from the Apache Git Service.
To resp
adutra commented on code in PR #8857:
URL: https://github.com/apache/iceberg/pull/8857#discussion_r1388462986
##
nessie/src/main/java/org/apache/iceberg/nessie/NessieIcebergClient.java:
##
@@ -181,133 +186,239 @@ public IcebergTable table(TableIdentifier
tableIdentifier) {
}
adutra commented on code in PR #8857:
URL: https://github.com/apache/iceberg/pull/8857#discussion_r1388456396
##
nessie/src/main/java/org/apache/iceberg/nessie/NessieIcebergClient.java:
##
@@ -181,133 +186,239 @@ public IcebergTable table(TableIdentifier
tableIdentifier) {
}
nastra commented on code in PR #8857:
URL: https://github.com/apache/iceberg/pull/8857#discussion_r1388414728
##
nessie/src/main/java/org/apache/iceberg/nessie/NessieIcebergClient.java:
##
@@ -181,133 +186,239 @@ public IcebergTable table(TableIdentifier
tableIdentifier) {
}
nastra commented on code in PR #8857:
URL: https://github.com/apache/iceberg/pull/8857#discussion_r1388413439
##
nessie/src/main/java/org/apache/iceberg/nessie/NessieIcebergClient.java:
##
@@ -181,133 +186,239 @@ public IcebergTable table(TableIdentifier
tableIdentifier) {
}
nastra commented on code in PR #8857:
URL: https://github.com/apache/iceberg/pull/8857#discussion_r1388412737
##
nessie/src/main/java/org/apache/iceberg/nessie/NessieIcebergClient.java:
##
@@ -181,133 +186,239 @@ public IcebergTable table(TableIdentifier
tableIdentifier) {
}
nastra commented on code in PR #8857:
URL: https://github.com/apache/iceberg/pull/8857#discussion_r1388407522
##
nessie/src/main/java/org/apache/iceberg/nessie/NessieIcebergClient.java:
##
@@ -181,133 +186,239 @@ public IcebergTable table(TableIdentifier
tableIdentifier) {
}
adutra commented on PR #8857:
URL: https://github.com/apache/iceberg/pull/8857#issuecomment-1804180229
Thanks @nastra for the review! I think I addressed all your remarks by now.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub
adutra commented on code in PR #8857:
URL: https://github.com/apache/iceberg/pull/8857#discussion_r1388272964
##
nessie/src/main/java/org/apache/iceberg/nessie/NessieIcebergClient.java:
##
@@ -181,133 +186,239 @@ public IcebergTable table(TableIdentifier
tableIdentifier) {
}
nastra commented on code in PR #8857:
URL: https://github.com/apache/iceberg/pull/8857#discussion_r1385038063
##
nessie/src/test/java/org/apache/iceberg/nessie/TestMultipleClients.java:
##
@@ -78,10 +81,19 @@ public void testListNamespaces() {
Assertions.assertThat(catalo
adutra commented on PR #8857:
URL: https://github.com/apache/iceberg/pull/8857#issuecomment-1792245820
@nastra can I get a review from you please? :-)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
dimas-b commented on code in PR #8857:
URL: https://github.com/apache/iceberg/pull/8857#discussion_r1373340680
##
nessie/src/main/java/org/apache/iceberg/nessie/NessieIcebergClient.java:
##
@@ -540,4 +612,59 @@ public void close() {
api.close();
}
}
+
+ private v
adutra commented on code in PR #8857:
URL: https://github.com/apache/iceberg/pull/8857#discussion_r1371727433
##
nessie/src/main/java/org/apache/iceberg/nessie/NessieIcebergClient.java:
##
@@ -181,133 +185,223 @@ public IcebergTable table(TableIdentifier
tableIdentifier) {
}
adutra commented on code in PR #8857:
URL: https://github.com/apache/iceberg/pull/8857#discussion_r1370653922
##
nessie/src/main/java/org/apache/iceberg/nessie/NessieIcebergClient.java:
##
@@ -181,133 +185,223 @@ public IcebergTable table(TableIdentifier
tableIdentifier) {
}
dimas-b commented on code in PR #8857:
URL: https://github.com/apache/iceberg/pull/8857#discussion_r1370594082
##
nessie/src/main/java/org/apache/iceberg/nessie/NessieIcebergClient.java:
##
@@ -181,133 +185,223 @@ public IcebergTable table(TableIdentifier
tableIdentifier) {
adutra commented on code in PR #8857:
URL: https://github.com/apache/iceberg/pull/8857#discussion_r1370572856
##
nessie/src/main/java/org/apache/iceberg/nessie/NessieIcebergClient.java:
##
@@ -181,133 +185,223 @@ public IcebergTable table(TableIdentifier
tableIdentifier) {
}
dimas-b commented on code in PR #8857:
URL: https://github.com/apache/iceberg/pull/8857#discussion_r1370419080
##
nessie/src/main/java/org/apache/iceberg/nessie/NessieIcebergClient.java:
##
@@ -181,133 +185,223 @@ public IcebergTable table(TableIdentifier
tableIdentifier) {
dimas-b commented on code in PR #8857:
URL: https://github.com/apache/iceberg/pull/8857#discussion_r1370336084
##
nessie/src/main/java/org/apache/iceberg/nessie/NessieIcebergClient.java:
##
@@ -181,133 +185,223 @@ public IcebergTable table(TableIdentifier
tableIdentifier) {
dimas-b commented on code in PR #8857:
URL: https://github.com/apache/iceberg/pull/8857#discussion_r1370331050
##
nessie/src/main/java/org/apache/iceberg/nessie/NessieIcebergClient.java:
##
@@ -181,133 +185,223 @@ public IcebergTable table(TableIdentifier
tableIdentifier) {
adutra commented on code in PR #8857:
URL: https://github.com/apache/iceberg/pull/8857#discussion_r1369938013
##
nessie/src/main/java/org/apache/iceberg/nessie/NessieIcebergClient.java:
##
@@ -540,4 +604,35 @@ public void close() {
api.close();
}
}
+
+ private vo
adutra commented on code in PR #8857:
URL: https://github.com/apache/iceberg/pull/8857#discussion_r1369932165
##
nessie/src/main/java/org/apache/iceberg/nessie/NessieIcebergClient.java:
##
@@ -181,133 +185,223 @@ public IcebergTable table(TableIdentifier
tableIdentifier) {
}
dimas-b commented on code in PR #8857:
URL: https://github.com/apache/iceberg/pull/8857#discussion_r1369427545
##
nessie/src/main/java/org/apache/iceberg/nessie/NessieIcebergClient.java:
##
@@ -323,28 +417,13 @@ public void renameTable(TableIdentifier from,
TableIdentifier to)
dimas-b commented on code in PR #8857:
URL: https://github.com/apache/iceberg/pull/8857#discussion_r1369419740
##
nessie/src/main/java/org/apache/iceberg/nessie/NessieIcebergClient.java:
##
@@ -181,133 +185,223 @@ public IcebergTable table(TableIdentifier
tableIdentifier) {
adutra commented on code in PR #8857:
URL: https://github.com/apache/iceberg/pull/8857#discussion_r1367434248
##
nessie/src/main/java/org/apache/iceberg/nessie/NessieIcebergClient.java:
##
@@ -181,133 +185,223 @@ public IcebergTable table(TableIdentifier
tableIdentifier) {
}
adutra commented on code in PR #8857:
URL: https://github.com/apache/iceberg/pull/8857#discussion_r1367436893
##
nessie/src/test/java/org/apache/iceberg/nessie/TestNamespace.java:
##
@@ -106,7 +106,7 @@ public void testCreatingAndDroppingNamespaceWithContent()
throws NessieNotF
adutra commented on code in PR #8857:
URL: https://github.com/apache/iceberg/pull/8857#discussion_r1367436336
##
nessie/src/main/java/org/apache/iceberg/nessie/NessieIcebergClient.java:
##
@@ -323,28 +417,13 @@ public void renameTable(TableIdentifier from,
TableIdentifier to) {
adutra commented on code in PR #8857:
URL: https://github.com/apache/iceberg/pull/8857#discussion_r1367434248
##
nessie/src/main/java/org/apache/iceberg/nessie/NessieIcebergClient.java:
##
@@ -181,133 +185,223 @@ public IcebergTable table(TableIdentifier
tableIdentifier) {
}
adutra commented on PR #8857:
URL: https://github.com/apache/iceberg/pull/8857#issuecomment-1773313071
Again ready for review, all namespace operations were re-implemented.
\cc @ajantha-bhat @dimas-b
--
This is an automated message from the Apache Git Service.
To respond to the mes
57 matches
Mail list logo
