Re: [PR] Migrate Scan, Schema and remaining Partition files in Core to JUnit5 [iceberg]

2024-03-21 Thread via GitHub
tomtongue commented on code in PR #10014: URL: https://github.com/apache/iceberg/pull/10014#discussion_r1534284283 ## core/src/test/java/org/apache/iceberg/TestSchemaUpdate.java: ## @@ -1733,22 +1706,19 @@ public void testRemoveIdentifierFields() { .setIdentifierFie

Re: [PR] Migrate Scan, Schema and remaining Partition files in Core to JUnit5 [iceberg]

2024-03-21 Thread via GitHub
nastra merged PR #10014: URL: https://github.com/apache/iceberg/pull/10014 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.ap

Re: [PR] Migrate Scan, Schema and remaining Partition files in Core to JUnit5 [iceberg]

2024-03-21 Thread via GitHub
tomtongue commented on code in PR #10014: URL: https://github.com/apache/iceberg/pull/10014#discussion_r1534269319 ## core/src/test/java/org/apache/iceberg/TestSchemaUpdate.java: ## @@ -1733,22 +1706,19 @@ public void testRemoveIdentifierFields() { .setIdentifierFie

Re: [PR] Migrate Scan, Schema and remaining Partition files in Core to JUnit5 [iceberg]

2024-03-21 Thread via GitHub
nastra commented on code in PR #10014: URL: https://github.com/apache/iceberg/pull/10014#discussion_r1534263933 ## core/src/test/java/org/apache/iceberg/TestSchemaUpdate.java: ## @@ -1733,22 +1706,19 @@ public void testRemoveIdentifierFields() { .setIdentifierFields

Re: [PR] Migrate Scan, Schema and remaining Partition files in Core to JUnit5 [iceberg]

2024-03-21 Thread via GitHub
tomtongue commented on PR #10014: URL: https://github.com/apache/iceberg/pull/10014#issuecomment-2012876402 @nastra Could you review this PR when you have time? (one more PR should be needed to complete the migration of core files in `org/apache/iceberg` to JUnit5) -- This is an au