nastra commented on code in PR #10014:
URL: https://github.com/apache/iceberg/pull/10014#discussion_r1534263933
##########
core/src/test/java/org/apache/iceberg/TestSchemaUpdate.java:
##########
@@ -1733,22 +1706,19 @@ public void testRemoveIdentifierFields() {
.setIdentifierFields("new_field", "new_field2")
.apply();
- Assert.assertEquals(
- "remove an identifier field should succeed",
- Sets.newHashSet(
- newSchema.findField("new_field").fieldId(),
- newSchema.findField("new_field2").fieldId()),
- newSchema.identifierFieldIds());
+ assertThat(newSchema.identifierFieldIds())
+ .as("remove an identifier field should succeed")
+ .isEqualTo(
Review Comment:
it's fine to also use `containsExactly()` here (and in other places)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
