Re: [PR] Make s3.request_timeout configurable [iceberg-python]

2025-02-10 Thread via GitHub
kevinjqliu commented on PR #1568: URL: https://github.com/apache/iceberg-python/pull/1568#issuecomment-2648753384 @metadaddy we're getting ready for the 0.9.0 as we speak :) heres the thread about it on slack https://apache-iceberg.slack.com/archives/C029EE6HQ5D/p1738367232843719

Re: [PR] Make s3.request_timeout configurable [iceberg-python]

2025-02-10 Thread via GitHub
metadaddy commented on PR #1568: URL: https://github.com/apache/iceberg-python/pull/1568#issuecomment-2648677030 @Fokko / @kevinjqliu Any plans for a release in the near future? It's been a while since 0.8.1, and I'd like to be able to use a mainline version of PyIceberg in my app, rather t

Re: [PR] Make s3.request_timeout configurable [iceberg-python]

2025-01-28 Thread via GitHub
Fokko commented on PR #1568: URL: https://github.com/apache/iceberg-python/pull/1568#issuecomment-2619075626 Thanks for working on this @metadaddy, and thanks @kevinjqliu for the review 🙌 -- This is an automated message from the Apache Git Service. To respond to the message, please log o

Re: [PR] Make s3.request_timeout configurable [iceberg-python]

2025-01-28 Thread via GitHub
Fokko merged PR #1568: URL: https://github.com/apache/iceberg-python/pull/1568 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceber

Re: [PR] Make s3.request_timeout configurable [iceberg-python]

2025-01-24 Thread via GitHub
kevinjqliu commented on code in PR #1568: URL: https://github.com/apache/iceberg-python/pull/1568#discussion_r1929414445 ## mkdocs/docs/configuration.md: ## @@ -116,6 +116,7 @@ For the FileIO there are several configuration options available: | s3.region| us-west-2

Re: [PR] Make s3.request_timeout configurable [iceberg-python]

2025-01-24 Thread via GitHub
metadaddy commented on PR #1568: URL: https://github.com/apache/iceberg-python/pull/1568#issuecomment-2613455318 @kevinjqliu Ah - it wanted imports in alphabetical order - I'd just inserted `S3_REQUEST_TIMEOUT` immediately after `S3_CONNECT_TIMEOUT`. All fixed now.1 -- This is an automate

Re: [PR] Make s3.request_timeout configurable [iceberg-python]

2025-01-24 Thread via GitHub
kevinjqliu commented on PR #1568: URL: https://github.com/apache/iceberg-python/pull/1568#issuecomment-2613211967 Looks like theres a lint issue, can you make `make lint` locally? @metadaddy -- This is an automated message from the Apache Git Service. To respond to the message, please log

Re: [PR] Make s3.request_timeout configurable [iceberg-python]

2025-01-24 Thread via GitHub
metadaddy commented on code in PR #1568: URL: https://github.com/apache/iceberg-python/pull/1568#discussion_r1929058246 ## pyiceberg/io/fsspec.py: ## @@ -150,6 +151,9 @@ def _s3(properties: Properties) -> AbstractFileSystem: if connect_timeout := properties.get(S3_CONNECT_T

Re: [PR] Make s3.request_timeout configurable [iceberg-python]

2025-01-24 Thread via GitHub
metadaddy commented on PR #1568: URL: https://github.com/apache/iceberg-python/pull/1568#issuecomment-2613110724 Hi @Fokko - your suggestion correction integrated and pushed. Thanks! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to Gi

Re: [PR] Make s3.request_timeout configurable [iceberg-python]

2025-01-24 Thread via GitHub
Fokko commented on code in PR #1568: URL: https://github.com/apache/iceberg-python/pull/1568#discussion_r1928631882 ## pyiceberg/io/fsspec.py: ## @@ -150,6 +151,9 @@ def _s3(properties: Properties) -> AbstractFileSystem: if connect_timeout := properties.get(S3_CONNECT_TIMEO

[PR] Make s3.request_timeout configurable [iceberg-python]

2025-01-23 Thread via GitHub
metadaddy opened a new pull request, #1568: URL: https://github.com/apache/iceberg-python/pull/1568 Similarly to #218, we see occasional timeout errors when writing data to S3-compatible object storage: ``` When uploading part for key 'drivestats/data/date_month=2014-08/0-0-9c