metadaddy commented on code in PR #1568:
URL: https://github.com/apache/iceberg-python/pull/1568#discussion_r1929058246
##########
pyiceberg/io/fsspec.py:
##########
@@ -150,6 +151,9 @@ def _s3(properties: Properties) -> AbstractFileSystem:
if connect_timeout := properties.get(S3_CONNECT_TIMEOUT):
config_kwargs["connect_timeout"] = float(connect_timeout)
+ if request_timeout := properties.get(S3_REQUEST_TIMEOUT):
+ config_kwargs["request_timeout"] = float(request_timeout)
Review Comment:
@Fokko You're entirely correct - thanks for catching that! I'll make the
correction and push the updated code.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
