Re: [PR] Make proxy endpoint configurable for s3 Http clients [iceberg]

2024-05-14 Thread via GitHub
flyrain commented on PR #10332: URL: https://github.com/apache/iceberg/pull/10332#issuecomment-2110766252 Thanks @amogh-jahagirdar and @nastra for the review. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL abo

Re: [PR] Make proxy endpoint configurable for s3 Http clients [iceberg]

2024-05-14 Thread via GitHub
flyrain merged PR #10332: URL: https://github.com/apache/iceberg/pull/10332 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.a

Re: [PR] Make proxy endpoint configurable for s3 Http clients [iceberg]

2024-05-14 Thread via GitHub
nastra commented on code in PR #10332: URL: https://github.com/apache/iceberg/pull/10332#discussion_r1599483955 ## docs/docs/aws.md: ## @@ -578,11 +578,12 @@ In contrast, URL Connection HTTP Client optimizes for minimum dependencies and s For more details of configuration, s

Re: [PR] Make proxy endpoint configurable for s3 Http clients [iceberg]

2024-05-13 Thread via GitHub
flyrain commented on PR #10332: URL: https://github.com/apache/iceberg/pull/10332#issuecomment-2109204549 Thanks @amogh-jahagirdar for the review. Resolved your comments. Would you like to take another look? -- This is an automated message from the Apache Git Service. To respond to the me

Re: [PR] Make proxy endpoint configurable for s3 Http clients [iceberg]

2024-05-13 Thread via GitHub
flyrain commented on code in PR #10332: URL: https://github.com/apache/iceberg/pull/10332#discussion_r1599301463 ## aws/src/main/java/org/apache/iceberg/aws/HttpClientProperties.java: ## @@ -52,6 +52,13 @@ public class HttpClientProperties implements Serializable { public sta

Re: [PR] Make proxy endpoint configurable for s3 Http clients [iceberg]

2024-05-13 Thread via GitHub
amogh-jahagirdar commented on code in PR #10332: URL: https://github.com/apache/iceberg/pull/10332#discussion_r1599254560 ## aws/src/main/java/org/apache/iceberg/aws/HttpClientProperties.java: ## @@ -52,6 +52,13 @@ public class HttpClientProperties implements Serializable { p

Re: [PR] Make proxy endpoint configurable for s3 Http clients [iceberg]

2024-05-13 Thread via GitHub
amogh-jahagirdar commented on code in PR #10332: URL: https://github.com/apache/iceberg/pull/10332#discussion_r1599254560 ## aws/src/main/java/org/apache/iceberg/aws/HttpClientProperties.java: ## @@ -52,6 +52,13 @@ public class HttpClientProperties implements Serializable { p

Re: [PR] Make proxy endpoint configurable for s3 Http clients [iceberg]

2024-05-13 Thread via GitHub
amogh-jahagirdar commented on code in PR #10332: URL: https://github.com/apache/iceberg/pull/10332#discussion_r1599249297 ## aws/src/main/java/org/apache/iceberg/aws/HttpClientProperties.java: ## @@ -52,6 +52,13 @@ public class HttpClientProperties implements Serializable { p