HonahX merged PR #695:
URL: https://github.com/apache/iceberg-python/pull/695
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg
HonahX commented on PR #695:
URL: https://github.com/apache/iceberg-python/pull/695#issuecomment-2098885056
@enkidulan Thanks for fixing the test and the great work! Thanks @syun64 and
@kevinjqliu for reviewing. Merging!
--
This is an automated message from the Apache Git Service.
To resp
enkidulan commented on PR #695:
URL: https://github.com/apache/iceberg-python/pull/695#issuecomment-2097627337
I pushed a small update to make Python 3.8 tests pass. I had to replace
`collections.abc.Iterator` with `typing.Iterator`, as the former only supports
subscripting starting with Py
enkidulan commented on PR #695:
URL: https://github.com/apache/iceberg-python/pull/695#issuecomment-2091494648
Thanks @syun64. I've added the tests
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
enkidulan commented on code in PR #695:
URL: https://github.com/apache/iceberg-python/pull/695#discussion_r1588306192
##
tests/integration/test_add_files.py:
##
@@ -122,8 +123,13 @@ def _create_table(
return tbl
+@pytest.fixture(name="format_version", params=[pytest.par
enkidulan commented on code in PR #695:
URL: https://github.com/apache/iceberg-python/pull/695#discussion_r1588306192
##
tests/integration/test_add_files.py:
##
@@ -122,8 +123,13 @@ def _create_table(
return tbl
+@pytest.fixture(name="format_version", params=[pytest.par
syun64 commented on PR #695:
URL: https://github.com/apache/iceberg-python/pull/695#issuecomment-2090959978
@enkidulan - thank you for working on this. I think
https://github.com/apache/iceberg-python/blob/main/tests/integration/test_add_files.py
is the right place for these tests
--
Thi
