enkidulan commented on code in PR #695:
URL: https://github.com/apache/iceberg-python/pull/695#discussion_r1588306192
##########
tests/integration/test_add_files.py:
##########
@@ -122,8 +123,13 @@ def _create_table(
return tbl
+@pytest.fixture(name="format_version", params=[pytest.param(1,
id="format_version=1"), pytest.param(2, id="format_version=2")])
+def format_version_fixure(request: pytest.FixtureRequest) -> Iterator[int]:
Review Comment:
Making params more human-friendly:
```
test_add_files_to_unpartitioned_table[format_version=1] PASSED
test_add_files_to_unpartitioned_table[format_version=2] PASSED
test_add_files_to_unpartitioned_table_raises_file_not_found[format_version=1]
PASSED
test_add_files_to_unpartitioned_table_raises_file_not_found[format_version=2]
PASSED
test_add_files_to_unpartitioned_table_raises_has_field_ids[format_version=1]
PASSED
test_add_files_to_unpartitioned_table_raises_has_field_ids[format_version=2]
PASSED
test_add_files_to_unpartitioned_table_with_schema_updates[format_version=1]
PASSED
test_add_files_to_unpartitioned_table_with_schema_updates[format_version=2]
PASSED
test_add_files_to_partitioned_table[format_version=1] PASSED
test_add_files_to_partitioned_table[format_version=2] PASSED
test_add_files_to_bucket_partitioned_table_fails[format_version=1] PASSED
test_add_files_to_bucket_partitioned_table_fails[format_version=2] PASSED
test_add_files_to_partitioned_table_fails_with_lower_and_upper_mismatch[format_version=1]
PASSED
test_add_files_to_partitioned_table_fails_with_lower_and_upper_mismatch[format_version=2]
PASSED
test_add_files_snapshot_properties[format_version=1] PASSED
test_add_files_snapshot_properties[format_version=2] PASSED
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
