kevinjqliu merged PR #1578:
URL: https://github.com/apache/iceberg-python/pull/1578
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@i
rshkv commented on code in PR #1578:
URL: https://github.com/apache/iceberg-python/pull/1578#discussion_r1929846312
##
tests/io/test_io.py:
##
@@ -281,6 +282,11 @@ def test_import_file_io_does_not_exist() -> None:
assert _import_file_io("pyiceberg.does.not.exist.FileIO", {}
kevinjqliu commented on code in PR #1578:
URL: https://github.com/apache/iceberg-python/pull/1578#discussion_r1929839265
##
tests/io/test_io.py:
##
@@ -281,6 +282,11 @@ def test_import_file_io_does_not_exist() -> None:
assert _import_file_io("pyiceberg.does.not.exist.FileIO
rshkv commented on PR #1578:
URL: https://github.com/apache/iceberg-python/pull/1578#issuecomment-2614539396
Updated the warnings for location providers and custom catalogs.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and
rshkv commented on code in PR #1578:
URL: https://github.com/apache/iceberg-python/pull/1578#discussion_r1929836366
##
tests/io/test_io.py:
##
@@ -281,6 +282,11 @@ def test_import_file_io_does_not_exist() -> None:
assert _import_file_io("pyiceberg.does.not.exist.FileIO", {}
kevinjqliu commented on code in PR #1578:
URL: https://github.com/apache/iceberg-python/pull/1578#discussion_r1929821411
##
pyiceberg/io/__init__.py:
##
@@ -316,7 +316,7 @@ def _import_file_io(io_impl: str, properties: Properties)
-> Optional[FileIO]:
class_ = getattr(
rshkv opened a new pull request, #1578:
URL: https://github.com/apache/iceberg-python/pull/1578
Closes #1577.
Log the underlying exception when a FileIO import fails.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and
