rshkv commented on code in PR #1578: URL: https://github.com/apache/iceberg-python/pull/1578#discussion_r1929836366
########## tests/io/test_io.py: ########## @@ -281,6 +282,11 @@ def test_import_file_io_does_not_exist() -> None: assert _import_file_io("pyiceberg.does.not.exist.FileIO", {}) is None +def test_import_file_io_logs_exception(caplog: Any) -> None: + _import_file_io("pyiceberg.does.not.exist.FileIO", {}) + assert "ModuleNotFoundError: No module named 'pyiceberg.does'" in caplog.text Review Comment: It fails here on `pyiceberg.does`. I presume that's Python trying and failing to import higher-level modules first? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org