fqaiser94 commented on code in PR #10792:
URL: https://github.com/apache/iceberg/pull/10792#discussion_r1696052319
##
kafka-connect/kafka-connect/src/main/java/org/apache/iceberg/connect/channel/CoordinatorThread.java:
##
@@ -65,5 +66,15 @@ boolean isTerminated() {
void ter
bryanck commented on code in PR #10792:
URL: https://github.com/apache/iceberg/pull/10792#discussion_r1696048433
##
kafka-connect/kafka-connect/src/main/java/org/apache/iceberg/connect/channel/CoordinatorThread.java:
##
@@ -65,5 +66,15 @@ boolean isTerminated() {
void termi
fqaiser94 commented on code in PR #10792:
URL: https://github.com/apache/iceberg/pull/10792#discussion_r1696035086
##
kafka-connect/kafka-connect/src/main/java/org/apache/iceberg/connect/channel/CoordinatorThread.java:
##
@@ -65,5 +66,15 @@ boolean isTerminated() {
void ter
fqaiser94 commented on code in PR #10792:
URL: https://github.com/apache/iceberg/pull/10792#discussion_r1696032626
##
kafka-connect/kafka-connect/src/main/java/org/apache/iceberg/connect/channel/CoordinatorThread.java:
##
@@ -65,5 +66,15 @@ boolean isTerminated() {
void ter
fqaiser94 commented on code in PR #10792:
URL: https://github.com/apache/iceberg/pull/10792#discussion_r1696029218
##
kafka-connect/kafka-connect/src/main/java/org/apache/iceberg/connect/channel/CoordinatorThread.java:
##
@@ -65,5 +66,15 @@ boolean isTerminated() {
void ter
bryanck commented on code in PR #10792:
URL: https://github.com/apache/iceberg/pull/10792#discussion_r1695665021
##
kafka-connect/kafka-connect/src/main/java/org/apache/iceberg/connect/channel/CoordinatorThread.java:
##
@@ -65,5 +66,15 @@ boolean isTerminated() {
void termi
bryanck commented on PR #10792:
URL: https://github.com/apache/iceberg/pull/10792#issuecomment-2256789099
Thanks for the reviews everyone, I'm going to close this and open a new one
after giving it some more thought.
--
This is an automated message from the Apache Git Service.
To respond
bryanck closed pull request #10792: Kafka Connect: Wait for coordinator shutdown
URL: https://github.com/apache/iceberg/pull/10792
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment
bryanck commented on code in PR #10792:
URL: https://github.com/apache/iceberg/pull/10792#discussion_r1695768314
##
kafka-connect/kafka-connect/src/main/java/org/apache/iceberg/connect/channel/CoordinatorThread.java:
##
@@ -65,5 +66,15 @@ boolean isTerminated() {
void termi
bryanck commented on code in PR #10792:
URL: https://github.com/apache/iceberg/pull/10792#discussion_r1695668628
##
kafka-connect/kafka-connect/src/main/java/org/apache/iceberg/connect/channel/CoordinatorThread.java:
##
@@ -65,5 +66,15 @@ boolean isTerminated() {
void termi
bryanck commented on code in PR #10792:
URL: https://github.com/apache/iceberg/pull/10792#discussion_r1695668628
##
kafka-connect/kafka-connect/src/main/java/org/apache/iceberg/connect/channel/CoordinatorThread.java:
##
@@ -65,5 +66,15 @@ boolean isTerminated() {
void termi
bryanck commented on code in PR #10792:
URL: https://github.com/apache/iceberg/pull/10792#discussion_r1695665021
##
kafka-connect/kafka-connect/src/main/java/org/apache/iceberg/connect/channel/CoordinatorThread.java:
##
@@ -65,5 +66,15 @@ boolean isTerminated() {
void termi
fqaiser94 commented on code in PR #10792:
URL: https://github.com/apache/iceberg/pull/10792#discussion_r1695632061
##
kafka-connect/kafka-connect/src/main/java/org/apache/iceberg/connect/channel/CoordinatorThread.java:
##
@@ -65,5 +66,15 @@ boolean isTerminated() {
void ter
singhpk234 commented on code in PR #10792:
URL: https://github.com/apache/iceberg/pull/10792#discussion_r1695631557
##
kafka-connect/kafka-connect/src/main/java/org/apache/iceberg/connect/channel/CoordinatorThread.java:
##
@@ -65,5 +66,15 @@ boolean isTerminated() {
void te
bryanck commented on code in PR #10792:
URL: https://github.com/apache/iceberg/pull/10792#discussion_r1695613576
##
kafka-connect/kafka-connect/src/main/java/org/apache/iceberg/connect/channel/CoordinatorThread.java:
##
@@ -65,5 +66,15 @@ boolean isTerminated() {
void termi
singhpk234 commented on code in PR #10792:
URL: https://github.com/apache/iceberg/pull/10792#discussion_r1695514258
##
kafka-connect/kafka-connect/src/main/java/org/apache/iceberg/connect/channel/CoordinatorThread.java:
##
@@ -65,5 +66,15 @@ boolean isTerminated() {
void te
ajantha-bhat commented on PR #10792:
URL: https://github.com/apache/iceberg/pull/10792#issuecomment-2255378369
cc: @fqaiser94, you might be interested in the review.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use th
bryanck opened a new pull request, #10792:
URL: https://github.com/apache/iceberg/pull/10792
This PR waits for the coordinator thread to complete when stopping the sink,
to ensure there are no coordinator tasks pending before starting a new
coordinator. The sink was designed with the assump
18 matches
Mail list logo
