bryanck commented on code in PR #10792: URL: https://github.com/apache/iceberg/pull/10792#discussion_r1696048433
########## kafka-connect/kafka-connect/src/main/java/org/apache/iceberg/connect/channel/CoordinatorThread.java: ########## @@ -65,5 +66,15 @@ boolean isTerminated() { void terminate() { terminated = true; + + try { + join(60_000); Review Comment: I feel like making an incremental improvement is still worthwhile while changes to Iceberg core are considered. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org