bryanck merged PR #10186:
URL: https://github.com/apache/iceberg/pull/10186
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.a
bryanck commented on PR #10186:
URL: https://github.com/apache/iceberg/pull/10186#issuecomment-2113284956
Thanks for the contribution @ajantha-bhat , it looks good!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
U
ajantha-bhat commented on PR #10186:
URL: https://github.com/apache/iceberg/pull/10186#issuecomment-2111667325
ping @bryanck
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
ajantha-bhat commented on code in PR #10186:
URL: https://github.com/apache/iceberg/pull/10186#discussion_r1595087812
##
kafka-connect/kafka-connect/src/test/java/org/apache/iceberg/connect/data/IcebergWriterFactoryTest.java:
##
@@ -47,7 +54,7 @@ public class IcebergWriterFactor
ajantha-bhat commented on code in PR #10186:
URL: https://github.com/apache/iceberg/pull/10186#discussion_r1595087423
##
kafka-connect/kafka-connect/src/test/java/org/apache/iceberg/connect/data/IcebergWriterFactoryTest.java:
##
@@ -83,4 +90,26 @@ public void testAutoCreateTable
bryanck commented on code in PR #10186:
URL: https://github.com/apache/iceberg/pull/10186#discussion_r1579467601
##
kafka-connect/kafka-connect/src/test/java/org/apache/iceberg/connect/data/IcebergWriterFactoryTest.java:
##
@@ -83,4 +90,26 @@ public void testAutoCreateTable(bool
ajantha-bhat commented on code in PR #10186:
URL: https://github.com/apache/iceberg/pull/10186#discussion_r1575543923
##
kafka-connect/kafka-connect/src/main/java/org/apache/iceberg/connect/data/IcebergWriterFactory.java:
##
@@ -112,4 +117,18 @@ Table autoCreateTable(String tabl
Fokko commented on code in PR #10186:
URL: https://github.com/apache/iceberg/pull/10186#discussion_r1572639039
##
kafka-connect/kafka-connect/src/main/java/org/apache/iceberg/connect/data/IcebergWriterFactory.java:
##
@@ -112,4 +117,18 @@ Table autoCreateTable(String tableName,
ajantha-bhat commented on code in PR #10186:
URL: https://github.com/apache/iceberg/pull/10186#discussion_r1572380923
##
kafka-connect/kafka-connect/src/test/java/org/apache/iceberg/connect/data/IcebergWriterFactoryTest.java:
##
@@ -83,4 +90,26 @@ public void testAutoCreateTable
ajantha-bhat commented on code in PR #10186:
URL: https://github.com/apache/iceberg/pull/10186#discussion_r1572380923
##
kafka-connect/kafka-connect/src/test/java/org/apache/iceberg/connect/data/IcebergWriterFactoryTest.java:
##
@@ -83,4 +90,26 @@ public void testAutoCreateTable
ajantha-bhat commented on code in PR #10186:
URL: https://github.com/apache/iceberg/pull/10186#discussion_r1572379348
##
kafka-connect/kafka-connect/src/test/java/org/apache/iceberg/connect/data/IcebergWriterFactoryTest.java:
##
@@ -47,7 +54,7 @@ public class IcebergWriterFactor
11 matches
Mail list logo