Re: [PR] Kafka-connect: Handle namespace creation for auto table creation [iceberg]

2024-05-15 Thread via GitHub
bryanck merged PR #10186: URL: https://github.com/apache/iceberg/pull/10186 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.a

Re: [PR] Kafka-connect: Handle namespace creation for auto table creation [iceberg]

2024-05-15 Thread via GitHub
bryanck commented on PR #10186: URL: https://github.com/apache/iceberg/pull/10186#issuecomment-2113284956 Thanks for the contribution @ajantha-bhat , it looks good! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the U

Re: [PR] Kafka-connect: Handle namespace creation for auto table creation [iceberg]

2024-05-14 Thread via GitHub
ajantha-bhat commented on PR #10186: URL: https://github.com/apache/iceberg/pull/10186#issuecomment-2111667325 ping @bryanck -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

Re: [PR] Kafka-connect: Handle namespace creation for auto table creation [iceberg]

2024-05-09 Thread via GitHub
ajantha-bhat commented on code in PR #10186: URL: https://github.com/apache/iceberg/pull/10186#discussion_r1595087812 ## kafka-connect/kafka-connect/src/test/java/org/apache/iceberg/connect/data/IcebergWriterFactoryTest.java: ## @@ -47,7 +54,7 @@ public class IcebergWriterFactor

Re: [PR] Kafka-connect: Handle namespace creation for auto table creation [iceberg]

2024-05-09 Thread via GitHub
ajantha-bhat commented on code in PR #10186: URL: https://github.com/apache/iceberg/pull/10186#discussion_r1595087423 ## kafka-connect/kafka-connect/src/test/java/org/apache/iceberg/connect/data/IcebergWriterFactoryTest.java: ## @@ -83,4 +90,26 @@ public void testAutoCreateTable

Re: [PR] Kafka-connect: Handle namespace creation for auto table creation [iceberg]

2024-04-25 Thread via GitHub
bryanck commented on code in PR #10186: URL: https://github.com/apache/iceberg/pull/10186#discussion_r1579467601 ## kafka-connect/kafka-connect/src/test/java/org/apache/iceberg/connect/data/IcebergWriterFactoryTest.java: ## @@ -83,4 +90,26 @@ public void testAutoCreateTable(bool

Re: [PR] Kafka-connect: Handle namespace creation for auto table creation [iceberg]

2024-04-22 Thread via GitHub
ajantha-bhat commented on code in PR #10186: URL: https://github.com/apache/iceberg/pull/10186#discussion_r1575543923 ## kafka-connect/kafka-connect/src/main/java/org/apache/iceberg/connect/data/IcebergWriterFactory.java: ## @@ -112,4 +117,18 @@ Table autoCreateTable(String tabl

Re: [PR] Kafka-connect: Handle namespace creation for auto table creation [iceberg]

2024-04-19 Thread via GitHub
Fokko commented on code in PR #10186: URL: https://github.com/apache/iceberg/pull/10186#discussion_r1572639039 ## kafka-connect/kafka-connect/src/main/java/org/apache/iceberg/connect/data/IcebergWriterFactory.java: ## @@ -112,4 +117,18 @@ Table autoCreateTable(String tableName,

Re: [PR] Kafka-connect: Handle namespace creation for auto table creation [iceberg]

2024-04-19 Thread via GitHub
ajantha-bhat commented on code in PR #10186: URL: https://github.com/apache/iceberg/pull/10186#discussion_r1572380923 ## kafka-connect/kafka-connect/src/test/java/org/apache/iceberg/connect/data/IcebergWriterFactoryTest.java: ## @@ -83,4 +90,26 @@ public void testAutoCreateTable

Re: [PR] Kafka-connect: Handle namespace creation for auto table creation [iceberg]

2024-04-19 Thread via GitHub
ajantha-bhat commented on code in PR #10186: URL: https://github.com/apache/iceberg/pull/10186#discussion_r1572380923 ## kafka-connect/kafka-connect/src/test/java/org/apache/iceberg/connect/data/IcebergWriterFactoryTest.java: ## @@ -83,4 +90,26 @@ public void testAutoCreateTable

Re: [PR] Kafka-connect: Handle namespace creation for auto table creation [iceberg]

2024-04-19 Thread via GitHub
ajantha-bhat commented on code in PR #10186: URL: https://github.com/apache/iceberg/pull/10186#discussion_r1572379348 ## kafka-connect/kafka-connect/src/test/java/org/apache/iceberg/connect/data/IcebergWriterFactoryTest.java: ## @@ -47,7 +54,7 @@ public class IcebergWriterFactor