Fokko commented on code in PR #10186:
URL: https://github.com/apache/iceberg/pull/10186#discussion_r1572639039
##########
kafka-connect/kafka-connect/src/main/java/org/apache/iceberg/connect/data/IcebergWriterFactory.java:
##########
@@ -112,4 +117,18 @@ Table autoCreateTable(String tableName, SinkRecord sample)
{
});
return result.get();
}
+
+ @VisibleForTesting
+ static void createNamespaceIfNotExist(Catalog catalog, Namespace
identifierNamespace) {
+ String[] levels = identifierNamespace.levels();
+ for (int index = 0; index < levels.length; index++) {
+ Namespace namespace = Namespace.of(Arrays.copyOfRange(levels, 0, index +
1));
+ try {
+ ((SupportsNamespaces) catalog).createNamespace(namespace);
+ } catch (AlreadyExistsException ex) {
Review Comment:
We went the other way with Flink: https://github.com/apache/iceberg/pull/7795
Can we also swallow the exception where the user doesn't have permission to
create a namespace.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
