Re: [PR] Implement update for `remove-snapshot-ref` action [iceberg-python]

2025-02-14 Thread via GitHub
Fokko merged PR #1598: URL: https://github.com/apache/iceberg-python/pull/1598 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceber

Re: [PR] Implement update for `remove-snapshot-ref` action [iceberg-python]

2025-02-14 Thread via GitHub
Fokko commented on PR #1598: URL: https://github.com/apache/iceberg-python/pull/1598#issuecomment-2660130311 @grihabor Sorry for not following up here, thanks for adding this, let's get this in 🚀 -- This is an automated message from the Apache Git Service. To respond to the message, plea

Re: [PR] Implement update for `remove-snapshot-ref` action [iceberg-python]

2025-02-13 Thread via GitHub
grihabor commented on PR #1598: URL: https://github.com/apache/iceberg-python/pull/1598#issuecomment-2657770025 @kevinjqliu @Fokko Shall we merge this? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to g

Re: [PR] Implement update for `remove-snapshot-ref` action [iceberg-python]

2025-02-10 Thread via GitHub
grihabor commented on PR #1598: URL: https://github.com/apache/iceberg-python/pull/1598#issuecomment-2649415003 Thank you! It passed now -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specif

Re: [PR] Implement update for `remove-snapshot-ref` action [iceberg-python]

2025-02-10 Thread via GitHub
kevinjqliu commented on PR #1598: URL: https://github.com/apache/iceberg-python/pull/1598#issuecomment-2648820748 I retrigger the test, we get intermittent failures from apache archive link -- This is an automated message from the Apache Git Service. To respond to the message, please log o

Re: [PR] Implement update for `remove-snapshot-ref` action [iceberg-python]

2025-02-10 Thread via GitHub
grihabor commented on PR #1598: URL: https://github.com/apache/iceberg-python/pull/1598#issuecomment-2648804738 looks like 3.12 failed because of some flaky build: ``` failed to solve: process "/bin/sh -c curl --retry 5 -s -C - [https://archive.apache.org/dist/spark/spark-${SPARK_VERSI

Re: [PR] Implement update for `remove-snapshot-ref` action [iceberg-python]

2025-02-10 Thread via GitHub
grihabor commented on PR #1598: URL: https://github.com/apache/iceberg-python/pull/1598#issuecomment-2647468438 @Fokko Thank you for review! Ready for another round -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the U

Re: [PR] Implement update for `remove-snapshot-ref` action [iceberg-python]

2025-02-10 Thread via GitHub
grihabor commented on code in PR #1598: URL: https://github.com/apache/iceberg-python/pull/1598#discussion_r1948730520 ## pyiceberg/table/update/snapshot.py: ## @@ -749,6 +750,28 @@ def _commit(self) -> UpdatesAndRequirements: """Apply the pending changes and commit."""

Re: [PR] Implement update for `remove-snapshot-ref` action [iceberg-python]

2025-02-03 Thread via GitHub
Fokko commented on PR #1598: URL: https://github.com/apache/iceberg-python/pull/1598#issuecomment-2630647678 Thanks for splitting this out 👍 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the s

Re: [PR] Implement update for `remove-snapshot-ref` action [iceberg-python]

2025-02-03 Thread via GitHub
Fokko commented on code in PR #1598: URL: https://github.com/apache/iceberg-python/pull/1598#discussion_r1939202531 ## pyiceberg/table/update/snapshot.py: ## @@ -749,6 +750,28 @@ def _commit(self) -> UpdatesAndRequirements: """Apply the pending changes and commit."""

Re: [PR] Implement update for `remove-snapshot-ref` action [iceberg-python]

2025-02-03 Thread via GitHub
Fokko commented on code in PR #1598: URL: https://github.com/apache/iceberg-python/pull/1598#discussion_r1939200058 ## pyiceberg/table/update/__init__.py: ## @@ -466,6 +466,21 @@ def _(update: SetSnapshotRefUpdate, base_metadata: TableMetadata, context: _Tabl return base_m

Re: [PR] Implement update for `remove-snapshot-ref` action [iceberg-python]

2025-02-03 Thread via GitHub
Fokko commented on code in PR #1598: URL: https://github.com/apache/iceberg-python/pull/1598#discussion_r1939197397 ## pyiceberg/table/update/__init__.py: ## @@ -466,6 +466,21 @@ def _(update: SetSnapshotRefUpdate, base_metadata: TableMetadata, context: _Tabl return base_m

Re: [PR] Implement update for `remove-snapshot-ref` action [iceberg-python]

2025-02-03 Thread via GitHub
Fokko commented on code in PR #1598: URL: https://github.com/apache/iceberg-python/pull/1598#discussion_r1939195894 ## pyiceberg/table/update/__init__.py: ## @@ -466,6 +466,21 @@ def _(update: SetSnapshotRefUpdate, base_metadata: TableMetadata, context: _Tabl return base_m

[PR] Implement update for `remove-snapshot-ref` action [iceberg-python]

2025-02-01 Thread via GitHub
grihabor opened a new pull request, #1598: URL: https://github.com/apache/iceberg-python/pull/1598 Part of https://github.com/apache/iceberg-python/pull/1561 Closes https://github.com/apache/iceberg-python/pull/822 -- This is an automated message from the Apache Git Service. To respond