Fokko commented on code in PR #1598:
URL: https://github.com/apache/iceberg-python/pull/1598#discussion_r1939202531
##########
pyiceberg/table/update/snapshot.py:
##########
@@ -749,6 +750,28 @@ def _commit(self) -> UpdatesAndRequirements:
"""Apply the pending changes and commit."""
return self._updates, self._requirements
+ def _remove_ref_snapshot(self, ref_name: str) -> ManageSnapshots:
+ """Remove a snapshot ref.
+
+ Args:
+ ref_name: branch / tag name to remove
+ Stages the updates and requirements for the remove-snapshot-ref.
+ Returns
+ This method for chaining
+ """
+ updates = (RemoveSnapshotRefUpdate(ref_name=ref_name),)
Review Comment:
Interesting, I would also expect that we would store if it is either a tag
or a branch.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
