Fokko merged PR #367:
URL: https://github.com/apache/iceberg-rust/pull/367
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.ap
liurenjie1024 commented on code in PR #367:
URL: https://github.com/apache/iceberg-rust/pull/367#discussion_r1638297920
##
crates/iceberg/src/expr/visitors/manifest_evaluator.rs:
##
@@ -103,98 +106,264 @@ impl BoundPredicateVisitor for ManifestFilterVisitor<'_>
{
refer
Fokko commented on code in PR #367:
URL: https://github.com/apache/iceberg-rust/pull/367#discussion_r1638292445
##
crates/iceberg/src/expr/visitors/manifest_evaluator.rs:
##
@@ -103,98 +106,264 @@ impl BoundPredicateVisitor for ManifestFilterVisitor<'_>
{
reference: &B
liurenjie1024 commented on PR #367:
URL: https://github.com/apache/iceberg-rust/pull/367#issuecomment-2165695873
cc @Fokko Do you want to take a review for this? I see you assigned yourself
for review.
--
This is an automated message from the Apache Git Service.
To respond to the message,
marvinlanhenke commented on code in PR #367:
URL: https://github.com/apache/iceberg-rust/pull/367#discussion_r1637582908
##
crates/iceberg/src/expr/visitors/manifest_evaluator.rs:
##
@@ -103,98 +106,255 @@ impl BoundPredicateVisitor for ManifestFilterVisitor<'_>
{
refe
liurenjie1024 commented on PR #367:
URL: https://github.com/apache/iceberg-rust/pull/367#issuecomment-2164182531
> Hi @liurenjie1024 - sorry to pester you but are you able to re-review this
please? It's the last major piece of the puzzle on the read side.
Hi, @sdd Sorry for delay. I'l
s-akhtar-baig commented on code in PR #367:
URL: https://github.com/apache/iceberg-rust/pull/367#discussion_r1637115175
##
crates/iceberg/src/expr/visitors/manifest_evaluator.rs:
##
@@ -103,98 +106,255 @@ impl BoundPredicateVisitor for ManifestFilterVisitor<'_>
{
refer
marvinlanhenke commented on code in PR #367:
URL: https://github.com/apache/iceberg-rust/pull/367#discussion_r1636945871
##
crates/iceberg/src/expr/visitors/manifest_evaluator.rs:
##
@@ -103,98 +106,255 @@ impl BoundPredicateVisitor for ManifestFilterVisitor<'_>
{
refe
marvinlanhenke commented on code in PR #367:
URL: https://github.com/apache/iceberg-rust/pull/367#discussion_r1636945871
##
crates/iceberg/src/expr/visitors/manifest_evaluator.rs:
##
@@ -103,98 +106,255 @@ impl BoundPredicateVisitor for ManifestFilterVisitor<'_>
{
refe
marvinlanhenke commented on code in PR #367:
URL: https://github.com/apache/iceberg-rust/pull/367#discussion_r1636931579
##
crates/iceberg/src/expr/visitors/manifest_evaluator.rs:
##
@@ -103,98 +106,255 @@ impl BoundPredicateVisitor for ManifestFilterVisitor<'_>
{
refe
marvinlanhenke commented on code in PR #367:
URL: https://github.com/apache/iceberg-rust/pull/367#discussion_r1636931579
##
crates/iceberg/src/expr/visitors/manifest_evaluator.rs:
##
@@ -103,98 +106,255 @@ impl BoundPredicateVisitor for ManifestFilterVisitor<'_>
{
refe
s-akhtar-baig commented on code in PR #367:
URL: https://github.com/apache/iceberg-rust/pull/367#discussion_r1636758827
##
crates/iceberg/src/expr/visitors/manifest_evaluator.rs:
##
@@ -103,98 +106,255 @@ impl BoundPredicateVisitor for ManifestFilterVisitor<'_>
{
refer
sdd commented on PR #367:
URL: https://github.com/apache/iceberg-rust/pull/367#issuecomment-2161359056
Hi @liurenjie1024 - sorry to pester you but are you able to re-review this
please? It's the last major piece of the puzzle on the read side.
--
This is an automated message from the Apa
s-akhtar-baig commented on PR #367:
URL: https://github.com/apache/iceberg-rust/pull/367#issuecomment-2158936026
@liurenjie1024 @marvinlanhenke @sdd, thank you for reviewing these changes
and for your feedback! Greatly appreciated!
I have pushed the required changes. Please let me kno
liurenjie1024 commented on code in PR #367:
URL: https://github.com/apache/iceberg-rust/pull/367#discussion_r1633057721
##
crates/iceberg/src/expr/visitors/manifest_evaluator.rs:
##
@@ -103,98 +106,245 @@ impl BoundPredicateVisitor for ManifestFilterVisitor<'_>
{
refer
sdd commented on code in PR #367:
URL: https://github.com/apache/iceberg-rust/pull/367#discussion_r1632753331
##
crates/iceberg/src/expr/visitors/manifest_evaluator.rs:
##
@@ -103,98 +106,245 @@ impl BoundPredicateVisitor for ManifestFilterVisitor<'_>
{
reference: &Bou
sdd commented on code in PR #367:
URL: https://github.com/apache/iceberg-rust/pull/367#discussion_r1632753331
##
crates/iceberg/src/expr/visitors/manifest_evaluator.rs:
##
@@ -103,98 +106,245 @@ impl BoundPredicateVisitor for ManifestFilterVisitor<'_>
{
reference: &Bou
liurenjie1024 commented on code in PR #367:
URL: https://github.com/apache/iceberg-rust/pull/367#discussion_r1624624064
##
crates/iceberg/src/expr/visitors/manifest_evaluator.rs:
##
@@ -221,67 +413,215 @@ impl ManifestFilterVisitor<'_> {
let pos = reference.accessor().p
s-akhtar-baig commented on code in PR #367:
URL: https://github.com/apache/iceberg-rust/pull/367#discussion_r1622704735
##
crates/iceberg/src/expr/visitors/manifest_evaluator.rs:
##
@@ -103,98 +106,264 @@ impl BoundPredicateVisitor for ManifestFilterVisitor<'_>
{
refer
s-akhtar-baig commented on code in PR #367:
URL: https://github.com/apache/iceberg-rust/pull/367#discussion_r1622706982
##
crates/iceberg/src/expr/visitors/manifest_evaluator.rs:
##
@@ -103,98 +106,264 @@ impl BoundPredicateVisitor for ManifestFilterVisitor<'_>
{
refer
s-akhtar-baig commented on code in PR #367:
URL: https://github.com/apache/iceberg-rust/pull/367#discussion_r1622705122
##
crates/iceberg/src/expr/visitors/manifest_evaluator.rs:
##
@@ -103,98 +106,264 @@ impl BoundPredicateVisitor for ManifestFilterVisitor<'_>
{
refer
s-akhtar-baig commented on code in PR #367:
URL: https://github.com/apache/iceberg-rust/pull/367#discussion_r1622704735
##
crates/iceberg/src/expr/visitors/manifest_evaluator.rs:
##
@@ -103,98 +106,264 @@ impl BoundPredicateVisitor for ManifestFilterVisitor<'_>
{
refer
liurenjie1024 commented on code in PR #367:
URL: https://github.com/apache/iceberg-rust/pull/367#discussion_r1611756781
##
crates/iceberg/src/expr/visitors/manifest_evaluator.rs:
##
@@ -103,98 +106,245 @@ impl BoundPredicateVisitor for ManifestFilterVisitor<'_>
{
refer
sdd commented on code in PR #367:
URL: https://github.com/apache/iceberg-rust/pull/367#discussion_r1609404309
##
crates/iceberg/src/expr/visitors/manifest_evaluator.rs:
##
@@ -103,98 +106,245 @@ impl BoundPredicateVisitor for ManifestFilterVisitor<'_>
{
reference: &Bou
sdd commented on code in PR #367:
URL: https://github.com/apache/iceberg-rust/pull/367#discussion_r1609384502
##
crates/iceberg/src/expr/visitors/manifest_evaluator.rs:
##
@@ -103,98 +106,245 @@ impl BoundPredicateVisitor for ManifestFilterVisitor<'_>
{
reference: &Bou
sdd commented on code in PR #367:
URL: https://github.com/apache/iceberg-rust/pull/367#discussion_r1609384502
##
crates/iceberg/src/expr/visitors/manifest_evaluator.rs:
##
@@ -103,98 +106,245 @@ impl BoundPredicateVisitor for ManifestFilterVisitor<'_>
{
reference: &Bou
marvinlanhenke commented on code in PR #367:
URL: https://github.com/apache/iceberg-rust/pull/367#discussion_r1602587866
##
crates/iceberg/src/expr/visitors/manifest_evaluator.rs:
##
@@ -103,98 +106,245 @@ impl BoundPredicateVisitor for ManifestFilterVisitor<'_>
{
refe
s-akhtar-baig commented on code in PR #367:
URL: https://github.com/apache/iceberg-rust/pull/367#discussion_r1602276980
##
crates/iceberg/src/expr/visitors/manifest_evaluator.rs:
##
@@ -103,98 +106,245 @@ impl BoundPredicateVisitor for ManifestFilterVisitor<'_>
{
refer
marvinlanhenke commented on code in PR #367:
URL: https://github.com/apache/iceberg-rust/pull/367#discussion_r1598017270
##
crates/iceberg/src/expr/visitors/manifest_evaluator.rs:
##
@@ -103,98 +106,245 @@ impl BoundPredicateVisitor for ManifestFilterVisitor<'_>
{
refe
sdd commented on code in PR #367:
URL: https://github.com/apache/iceberg-rust/pull/367#discussion_r1597956781
##
crates/iceberg/src/expr/visitors/manifest_evaluator.rs:
##
@@ -203,16 +353,39 @@ impl BoundPredicateVisitor for ManifestFilterVisitor<'_> {
literals: &FnvHas
sdd commented on code in PR #367:
URL: https://github.com/apache/iceberg-rust/pull/367#discussion_r1597952306
##
crates/iceberg/src/expr/visitors/manifest_evaluator.rs:
##
@@ -221,67 +394,213 @@ impl ManifestFilterVisitor<'_> {
let pos = reference.accessor().position();
sdd commented on code in PR #367:
URL: https://github.com/apache/iceberg-rust/pull/367#discussion_r1597949796
##
crates/iceberg/src/expr/visitors/manifest_evaluator.rs:
##
@@ -103,98 +106,245 @@ impl BoundPredicateVisitor for ManifestFilterVisitor<'_>
{
reference: &Bou
sdd commented on code in PR #367:
URL: https://github.com/apache/iceberg-rust/pull/367#discussion_r1597946439
##
crates/iceberg/src/expr/visitors/manifest_evaluator.rs:
##
@@ -103,98 +106,245 @@ impl BoundPredicateVisitor for ManifestFilterVisitor<'_>
{
reference: &Bou
s-akhtar-baig commented on PR #367:
URL: https://github.com/apache/iceberg-rust/pull/367#issuecomment-2105247342
@sdd, thank you for reviewing the changes and providing references! I have
modified my code based on your suggestions. Please take a look and let me know
if I miss anything.
--
sdd commented on code in PR #367:
URL: https://github.com/apache/iceberg-rust/pull/367#discussion_r1596298705
##
crates/iceberg/src/expr/visitors/manifest_evaluator.rs:
##
@@ -98,103 +101,249 @@ impl BoundPredicateVisitor for ManifestFilterVisitor<'_>
{
Ok(self.field_s
s-akhtar-baig opened a new pull request, #367:
URL: https://github.com/apache/iceberg-rust/pull/367
GitHub issue: https://github.com/apache/iceberg-rust/issues/350
Description: ManifestEvaluator was implemented in
https://github.com/apache/iceberg-rust/pull/322 whereas some functions
36 matches
Mail list logo
