marvinlanhenke commented on code in PR #367: URL: https://github.com/apache/iceberg-rust/pull/367#discussion_r1602587866
########## crates/iceberg/src/expr/visitors/manifest_evaluator.rs: ########## @@ -103,98 +106,245 @@ impl BoundPredicateVisitor for ManifestFilterVisitor<'_> { reference: &BoundReference, _predicate: &BoundPredicate, ) -> crate::Result<bool> { - todo!() + let field: &FieldSummary = self.field_summary_for_reference(reference); + + // contains_null encodes whether at least one partition value is null, + // lowerBound is null if all partition values are null + if self.are_all_null(field, &reference.field().field_type) { Review Comment: ups sorry my mistake here -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org