Re: [PR] Hive locking [iceberg-python]

2024-02-10 Thread via GitHub
danielcweeks merged PR #405: URL: https://github.com/apache/iceberg-python/pull/405 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@i

Re: [PR] Hive locking [iceberg-python]

2024-02-10 Thread via GitHub
danielcweeks commented on code in PR #405: URL: https://github.com/apache/iceberg-python/pull/405#discussion_r1485173447 ## pyiceberg/catalog/hive.py: ## @@ -363,15 +381,23 @@ def _commit_table(self, table_request: CommitTableRequest) -> CommitTableRespons self._write_

Re: [PR] Hive locking [iceberg-python]

2024-02-10 Thread via GitHub
danielcweeks commented on code in PR #405: URL: https://github.com/apache/iceberg-python/pull/405#discussion_r1485172192 ## tests/integration/test_reads.py: ## @@ -467,3 +469,26 @@ def test_null_list_and_map(catalog: Catalog) -> None: # assert arrow_table["col_list_with_str

Re: [PR] Hive locking [iceberg-python]

2024-02-10 Thread via GitHub
amogh-jahagirdar commented on code in PR #405: URL: https://github.com/apache/iceberg-python/pull/405#discussion_r1485171524 ## pyiceberg/catalog/hive.py: ## @@ -363,15 +381,23 @@ def _commit_table(self, table_request: CommitTableRequest) -> CommitTableRespons self._wr

Re: [PR] Hive locking [iceberg-python]

2024-02-10 Thread via GitHub
Fokko commented on code in PR #405: URL: https://github.com/apache/iceberg-python/pull/405#discussion_r1485146614 ## tests/integration/test_reads.py: ## @@ -467,3 +469,26 @@ def test_null_list_and_map(catalog: Catalog) -> None: # assert arrow_table["col_list_with_struct"].t

Re: [PR] Hive locking [iceberg-python]

2024-02-09 Thread via GitHub
Fokko commented on code in PR #405: URL: https://github.com/apache/iceberg-python/pull/405#discussion_r1484994993 ## pyiceberg/catalog/hive.py: ## @@ -155,7 +164,7 @@ def _construct_hive_storage_descriptor(schema: Schema, location: Optional[str]) PROP_TABLE_TYPE = "table_type"