amogh-jahagirdar commented on code in PR #405:
URL: https://github.com/apache/iceberg-python/pull/405#discussion_r1485171524
##########
pyiceberg/catalog/hive.py:
##########
@@ -363,15 +381,23 @@ def _commit_table(self, table_request:
CommitTableRequest) -> CommitTableRespons
self._write_metadata(updated_metadata, current_table.io,
new_metadata_location)
# commit to hive
- try:
- with self._client as open_client:
+ #
https://github.com/apache/hive/blob/master/standalone-metastore/metastore-common/src/main/thrift/hive_metastore.thrift#L1232
+ with self._client as open_client:
+ lock: LockResponse =
open_client.lock(self._create_lock_request(database_name, table_name))
+
+ try:
+ if lock.state != LockState.ACQUIRED:
+ raise CommitFailedException(f"Failed to acquire lock for
{table_request.identifier}, state: {lock.state}")
+
tbl = open_client.get_table(dbname=database_name,
tbl_name=table_name)
tbl.parameters = _construct_parameters(
metadata_location=new_metadata_location,
previous_metadata_location=current_table.metadata_location
)
open_client.alter_table(dbname=database_name,
tbl_name=table_name, new_tbl=tbl)
- except NoSuchObjectException as e:
- raise NoSuchTableError(f"Table does not exist: {table_name}") from
e
+ except NoSuchObjectException as e:
+ raise NoSuchTableError(f"Table does not exist: {table_name}")
from e
+ finally:
+ open_client.unlock(UnlockRequest(lockid=lock.lockid))
Review Comment:
Don't consider this a blocker, but it'd be nice to have a test to verify
that in case of any exception thrown we do actually perform the unlock.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
