Re: [PR] Hive: Add DO_NOT_UPDATE_STATS in alter_table [iceberg-python]

2025-05-06 Thread via GitHub
kevinjqliu merged PR #1966: URL: https://github.com/apache/iceberg-python/pull/1966 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@i

Re: [PR] Hive: Add DO_NOT_UPDATE_STATS in alter_table [iceberg-python]

2025-05-05 Thread via GitHub
frankliee commented on code in PR #1966: URL: https://github.com/apache/iceberg-python/pull/1966#discussion_r2074582752 ## pyiceberg/catalog/hive.py: ## @@ -135,6 +136,8 @@ DEFAULT_LOCK_CHECK_MIN_WAIT_TIME = 0.1 # 100 milliseconds DEFAULT_LOCK_CHECK_MAX_WAIT_TIME = 60 # 1 mi

Re: [PR] Hive: Add DO_NOT_UPDATE_STATS in alter_table [iceberg-python]

2025-05-05 Thread via GitHub
frankliee commented on code in PR #1966: URL: https://github.com/apache/iceberg-python/pull/1966#discussion_r2074559857 ## pyiceberg/catalog/hive.py: ## @@ -135,6 +136,8 @@ DEFAULT_LOCK_CHECK_MIN_WAIT_TIME = 0.1 # 100 milliseconds DEFAULT_LOCK_CHECK_MAX_WAIT_TIME = 60 # 1 mi

Re: [PR] Hive: Add DO_NOT_UPDATE_STATS in alter_table [iceberg-python]

2025-05-05 Thread via GitHub
kevinjqliu commented on code in PR #1966: URL: https://github.com/apache/iceberg-python/pull/1966#discussion_r2073790982 ## pyiceberg/catalog/hive.py: ## @@ -135,6 +136,8 @@ DEFAULT_LOCK_CHECK_MIN_WAIT_TIME = 0.1 # 100 milliseconds DEFAULT_LOCK_CHECK_MAX_WAIT_TIME = 60 # 1 m

[PR] Hive: Add DO_NOT_UPDATE_STATS in alter_table [iceberg-python]

2025-05-04 Thread via GitHub
frankliee opened a new pull request, #1966: URL: https://github.com/apache/iceberg-python/pull/1966 # Rationale for this change Let the hive metastore does not compute hive stats which is not used by iceberg. # Are these changes tested? Existing tests