kevinjqliu commented on code in PR #1966: URL: https://github.com/apache/iceberg-python/pull/1966#discussion_r2073790982
########## pyiceberg/catalog/hive.py: ########## @@ -135,6 +136,8 @@ DEFAULT_LOCK_CHECK_MIN_WAIT_TIME = 0.1 # 100 milliseconds DEFAULT_LOCK_CHECK_MAX_WAIT_TIME = 60 # 1 min DEFAULT_LOCK_CHECK_RETRIES = 4 +DO_NOT_UPDATE_STATS = "DO_NOT_UPDATE_STATS" +TRUE = "true" Review Comment: we should always verify if this should be the string `true` or the boolean `True` ########## pyiceberg/catalog/hive.py: ########## @@ -135,6 +136,8 @@ DEFAULT_LOCK_CHECK_MIN_WAIT_TIME = 0.1 # 100 milliseconds DEFAULT_LOCK_CHECK_MAX_WAIT_TIME = 60 # 1 min DEFAULT_LOCK_CHECK_RETRIES = 4 +DO_NOT_UPDATE_STATS = "DO_NOT_UPDATE_STATS" +TRUE = "true" Review Comment: nit maybe something like ```suggestion DO_NOT_UPDATE_STATS_DEFAULT = "true" ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org
