hesham-medhat commented on PR #11039:
URL: https://github.com/apache/iceberg/pull/11039#issuecomment-2707861898
Thanks for finding the time, Ryan. Unironically, now **I** am on a long
medical leave, but Google is committed to this, and we will find the time to
finalize this review soon.
-
github-actions[bot] commented on PR #11039:
URL: https://github.com/apache/iceberg/pull/11039#issuecomment-2707763058
This pull request has been marked as stale due to 30 days of inactivity. It
will be closed in 1 week if no further activity occurs. If you think that’s
incorrect or this pul
rdblue commented on code in PR #11039:
URL: https://github.com/apache/iceberg/pull/11039#discussion_r1943623327
##
build.gradle:
##
@@ -157,7 +157,7 @@ subprojects {
rootTask.finalizedBy showDeprecationRulesOnRevApiFailure
}
}
-
+
Review Comment:
Unn
rdblue commented on code in PR #11039:
URL: https://github.com/apache/iceberg/pull/11039#discussion_r1943622533
##
build.gradle:
##
@@ -636,6 +636,45 @@ project(':iceberg-delta-lake') {
}
}
+project(':iceberg-bigquery') {
+ test {
+useJUnitPlatform()
+ }
+
+ depende
rdblue commented on code in PR #11039:
URL: https://github.com/apache/iceberg/pull/11039#discussion_r194362
##
build.gradle:
##
@@ -636,6 +636,45 @@ project(':iceberg-delta-lake') {
}
}
+project(':iceberg-bigquery') {
+ test {
+useJUnitPlatform()
+ }
+
+ depende
rdblue commented on code in PR #11039:
URL: https://github.com/apache/iceberg/pull/11039#discussion_r1943620170
##
bigquery/src/main/java/org/apache/iceberg/gcp/bigquery/metastore/BigQueryMetastoreCatalog.java:
##
@@ -0,0 +1,328 @@
+/*
+ * Licensed to the Apache Software Foundat
rdblue commented on code in PR #11039:
URL: https://github.com/apache/iceberg/pull/11039#discussion_r1943619867
##
bigquery/src/main/java/org/apache/iceberg/gcp/bigquery/metastore/BigQueryMetastoreCatalog.java:
##
@@ -0,0 +1,328 @@
+/*
+ * Licensed to the Apache Software Foundat
rdblue commented on code in PR #11039:
URL: https://github.com/apache/iceberg/pull/11039#discussion_r1943617650
##
bigquery/src/main/java/org/apache/iceberg/gcp/bigquery/metastore/BigQueryMetastoreCatalog.java:
##
@@ -0,0 +1,328 @@
+/*
+ * Licensed to the Apache Software Foundat
rdblue commented on code in PR #11039:
URL: https://github.com/apache/iceberg/pull/11039#discussion_r1943617650
##
bigquery/src/main/java/org/apache/iceberg/gcp/bigquery/metastore/BigQueryMetastoreCatalog.java:
##
@@ -0,0 +1,328 @@
+/*
+ * Licensed to the Apache Software Foundat
rdblue commented on code in PR #11039:
URL: https://github.com/apache/iceberg/pull/11039#discussion_r1943616455
##
bigquery/src/main/java/org/apache/iceberg/gcp/bigquery/metastore/BigQueryMetastoreCatalog.java:
##
@@ -0,0 +1,328 @@
+/*
+ * Licensed to the Apache Software Foundat
rdblue commented on code in PR #11039:
URL: https://github.com/apache/iceberg/pull/11039#discussion_r1943615685
##
bigquery/src/main/java/org/apache/iceberg/gcp/bigquery/metastore/BigQueryMetastoreCatalog.java:
##
@@ -0,0 +1,328 @@
+/*
+ * Licensed to the Apache Software Foundat
rdblue commented on code in PR #11039:
URL: https://github.com/apache/iceberg/pull/11039#discussion_r1943611905
##
bigquery/src/main/java/org/apache/iceberg/gcp/bigquery/metastore/BigQueryMetastoreCatalog.java:
##
@@ -0,0 +1,328 @@
+/*
+ * Licensed to the Apache Software Foundat
rdblue commented on code in PR #11039:
URL: https://github.com/apache/iceberg/pull/11039#discussion_r1943611005
##
bigquery/src/main/java/org/apache/iceberg/gcp/bigquery/metastore/BigQueryMetastoreCatalog.java:
##
@@ -0,0 +1,328 @@
+/*
+ * Licensed to the Apache Software Foundat
rdblue commented on code in PR #11039:
URL: https://github.com/apache/iceberg/pull/11039#discussion_r1943610664
##
bigquery/src/main/java/org/apache/iceberg/gcp/bigquery/metastore/BigQueryMetastoreCatalog.java:
##
@@ -0,0 +1,328 @@
+/*
+ * Licensed to the Apache Software Foundat
rdblue commented on code in PR #11039:
URL: https://github.com/apache/iceberg/pull/11039#discussion_r1943610203
##
bigquery/src/main/java/org/apache/iceberg/gcp/bigquery/metastore/BigQueryMetastoreCatalog.java:
##
@@ -0,0 +1,328 @@
+/*
+ * Licensed to the Apache Software Foundat
rdblue commented on code in PR #11039:
URL: https://github.com/apache/iceberg/pull/11039#discussion_r1943609820
##
bigquery/src/main/java/org/apache/iceberg/gcp/bigquery/metastore/BigQueryMetastoreCatalog.java:
##
@@ -0,0 +1,328 @@
+/*
+ * Licensed to the Apache Software Foundat
rdblue commented on code in PR #11039:
URL: https://github.com/apache/iceberg/pull/11039#discussion_r1943608036
##
bigquery/src/main/java/org/apache/iceberg/gcp/bigquery/metastore/BigQueryMetastoreCatalog.java:
##
@@ -0,0 +1,328 @@
+/*
+ * Licensed to the Apache Software Foundat
rdblue commented on code in PR #11039:
URL: https://github.com/apache/iceberg/pull/11039#discussion_r1943605981
##
bigquery/src/main/java/org/apache/iceberg/gcp/bigquery/BigQueryClient.java:
##
@@ -0,0 +1,129 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
rdblue commented on code in PR #11039:
URL: https://github.com/apache/iceberg/pull/11039#discussion_r1943579431
##
bigquery/src/main/java/org/apache/iceberg/gcp/bigquery/BigQueryClient.java:
##
@@ -0,0 +1,129 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
rdblue commented on code in PR #11039:
URL: https://github.com/apache/iceberg/pull/11039#discussion_r1943575699
##
bigquery/src/main/java/org/apache/iceberg/gcp/bigquery/BigQueryClientImpl.java:
##
@@ -0,0 +1,492 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under
rdblue commented on code in PR #11039:
URL: https://github.com/apache/iceberg/pull/11039#discussion_r1943574434
##
bigquery/src/main/java/org/apache/iceberg/gcp/bigquery/BigQueryClientImpl.java:
##
@@ -0,0 +1,492 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under
rdblue commented on code in PR #11039:
URL: https://github.com/apache/iceberg/pull/11039#discussion_r1943572308
##
bigquery/src/main/java/org/apache/iceberg/gcp/bigquery/BigQueryClientImpl.java:
##
@@ -0,0 +1,492 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under
rdblue commented on code in PR #11039:
URL: https://github.com/apache/iceberg/pull/11039#discussion_r1943571247
##
bigquery/src/main/java/org/apache/iceberg/gcp/bigquery/BigQueryClientImpl.java:
##
@@ -0,0 +1,492 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under
rdblue commented on code in PR #11039:
URL: https://github.com/apache/iceberg/pull/11039#discussion_r1943569098
##
bigquery/src/main/java/org/apache/iceberg/gcp/bigquery/BigQueryClientImpl.java:
##
@@ -0,0 +1,492 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under
rdblue commented on code in PR #11039:
URL: https://github.com/apache/iceberg/pull/11039#discussion_r1943568625
##
bigquery/src/main/java/org/apache/iceberg/gcp/bigquery/BigQueryClientImpl.java:
##
@@ -0,0 +1,492 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under
rdblue commented on code in PR #11039:
URL: https://github.com/apache/iceberg/pull/11039#discussion_r1943567072
##
bigquery/src/main/java/org/apache/iceberg/gcp/bigquery/BigQueryClientImpl.java:
##
@@ -0,0 +1,492 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under
rdblue commented on code in PR #11039:
URL: https://github.com/apache/iceberg/pull/11039#discussion_r1943563130
##
bigquery/src/main/java/org/apache/iceberg/gcp/bigquery/metastore/BigQueryMetastoreCatalog.java:
##
@@ -0,0 +1,328 @@
+/*
+ * Licensed to the Apache Software Foundat
emkornfield commented on PR #11039:
URL: https://github.com/apache/iceberg/pull/11039#issuecomment-2623021449
> > @hesham-medhat @rdblue - could you pls give an update on this PR? It
seems it would massively simplify the Iceberg table management in GCP for
non-spark usecases.
> > thanks!
vrishin-bolt commented on PR #11039:
URL: https://github.com/apache/iceberg/pull/11039#issuecomment-2574498242
> @hesham-medhat @rdblue - could you pls give an update on this PR? It seems
it would massively simplify the Iceberg table management in GCP for non-spark
usecases.
>
> than
brunsgaard commented on PR #11039:
URL: https://github.com/apache/iceberg/pull/11039#issuecomment-2558261178
This issue is increasingly concerning for the community. GCP intends to
introduce Iceberg as a first-class citizen, but it is perplexing that this
initiative is continually being pos
z-kovacs commented on PR #11039:
URL: https://github.com/apache/iceberg/pull/11039#issuecomment-2546090559
Hi @hesham-medhat @rdblue - could you give us an update whether this
expected to be merged or for some reason this angle has been abandoned by
Iceberg / GCP teams?
it is a gre
github-actions[bot] commented on PR #11039:
URL: https://github.com/apache/iceberg/pull/11039#issuecomment-2544225522
This pull request has been marked as stale due to 30 days of inactivity. It
will be closed in 1 week if no further activity occurs. If you think that’s
incorrect or this pul
hesham-medhat commented on PR #11039:
URL: https://github.com/apache/iceberg/pull/11039#issuecomment-2479805549
Thank you all for your enthusiasm! This is close, it's pending @rdblue's
final pass/approval. A little while ago he told me he has been busy
nevertheless will get to it as soon as
k-alkiek commented on PR #11039:
URL: https://github.com/apache/iceberg/pull/11039#issuecomment-2479396505
This would be a great addition. Love to see the collaboration with GCP.
@rdblue, can we get it across the finish line?
--
This is an automated message from the Apache Git Service.
To
brunsgaard commented on PR #11039:
URL: https://github.com/apache/iceberg/pull/11039#issuecomment-2475686917
@hesham-medhat @rdblue, like @z-kovacs I would also really appreciate an
update on this if possible<3
--
This is an automated message from the Apache Git Service.
To respond to th
z-kovacs commented on PR #11039:
URL: https://github.com/apache/iceberg/pull/11039#issuecomment-2473076906
@hesham-medhat @rdblue - could you pls give an update on this PR? It seems
it would massively simplify the Iceberg table management in GCP for non-spark
usecases.
thanks!
--
github-actions[bot] commented on PR #11039:
URL: https://github.com/apache/iceberg/pull/11039#issuecomment-2469334657
This pull request has been marked as stale due to 30 days of inactivity. It
will be closed in 1 week if no further activity occurs. If you think that’s
incorrect or this pul
hesham-medhat commented on code in PR #11039:
URL: https://github.com/apache/iceberg/pull/11039#discussion_r1755908398
##
build.gradle:
##
@@ -647,20 +647,43 @@ project(':iceberg-gcp') {
implementation project(':iceberg-common')
implementation project(':iceberg-core')
hesham-medhat commented on code in PR #11039:
URL: https://github.com/apache/iceberg/pull/11039#discussion_r1755903459
##
gcp/src/main/java/org/apache/iceberg/gcp/bigquery/BigQueryClientImpl.java:
##
@@ -0,0 +1,481 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) unde
hesham-medhat commented on PR #11039:
URL: https://github.com/apache/iceberg/pull/11039#issuecomment-2345020069
> Hi @hesham-medhat , I assume this PR will also enable read/write support
for Flink pipelines that use BigLake external tables with BigQuery?
Hi @brunsgaard! No. This one i
rdblue commented on code in PR #11039:
URL: https://github.com/apache/iceberg/pull/11039#discussion_r1755571530
##
gcp/src/main/java/org/apache/iceberg/gcp/bigquery/BigQueryClientImpl.java:
##
@@ -0,0 +1,481 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+
rdblue commented on code in PR #11039:
URL: https://github.com/apache/iceberg/pull/11039#discussion_r1755570976
##
gcp/src/main/java/org/apache/iceberg/gcp/bigquery/BigQueryClientImpl.java:
##
@@ -0,0 +1,481 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+
rdblue commented on code in PR #11039:
URL: https://github.com/apache/iceberg/pull/11039#discussion_r1755564516
##
gcp/src/main/java/org/apache/iceberg/gcp/bigquery/BigQueryClientImpl.java:
##
@@ -0,0 +1,481 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+
rdblue commented on code in PR #11039:
URL: https://github.com/apache/iceberg/pull/11039#discussion_r178263
##
build.gradle:
##
@@ -647,20 +647,43 @@ project(':iceberg-gcp') {
implementation project(':iceberg-common')
implementation project(':iceberg-core')
+
brunsgaard commented on PR #11039:
URL: https://github.com/apache/iceberg/pull/11039#issuecomment-2344644652
Hi @hesham-medhat ,
I assume this PR will also enable read/write support for Flink pipelines
that use BigLake external tables with BigQuery?
--
This is an automated message from
hesham-medhat commented on code in PR #11039:
URL: https://github.com/apache/iceberg/pull/11039#discussion_r1755320886
##
build.gradle:
##
@@ -647,20 +647,43 @@ project(':iceberg-gcp') {
implementation project(':iceberg-common')
implementation project(':iceberg-core')
hesham-medhat commented on code in PR #11039:
URL: https://github.com/apache/iceberg/pull/11039#discussion_r1755322285
##
.gitignore:
##
@@ -66,3 +66,6 @@ metastore_db/
# Spark/metastore files
spark-warehouse/
derby.log
+
+# BigQuery/metastore files
+gcp/db_folder/
Review Co
hesham-medhat commented on code in PR #11039:
URL: https://github.com/apache/iceberg/pull/11039#discussion_r1755319360
##
build.gradle:
##
@@ -647,20 +647,43 @@ project(':iceberg-gcp') {
implementation project(':iceberg-common')
implementation project(':iceberg-core')
rdblue commented on code in PR #11039:
URL: https://github.com/apache/iceberg/pull/11039#discussion_r1752779009
##
build.gradle:
##
@@ -647,20 +647,43 @@ project(':iceberg-gcp') {
implementation project(':iceberg-common')
implementation project(':iceberg-core')
+
49 matches
Mail list logo
